Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix octal bug in ocean post #1712

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix octal bug in ocean post #1712

merged 1 commit into from
Jun 26, 2023

Conversation

WalterKolczynski-NOAA
Copy link
Contributor

Description

Ocean post was incorrectly treating zero-padded forecast hours as octals. This is now fixed.

Fixes #1710
Refs #1195

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • P8 on Orion

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes

@WalterKolczynski-NOAA
Fix octal bug in ocean post
4cfa25d 
Ocean post was incorrectly treating zero-padded forecast hours as octals.
This is now fixed.

Fixes NOAA-EMC#1710
Refs NOAA-EMC#1195
@WalterKolczynski-NOAA WalterKolczynski-NOAA self-assigned this Jun 24, 2023
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Jun 24, 2023
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Jun 24, 2023
@emcbot
Copy link

emcbot commented Jun 24, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Sat Jun 24 00:24:58 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Sat Jun 24 00:30:23 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Sat Jun 24 01:36:20 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:24 UTC 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:27 UTC 2023 for experiment C96C48_hybatmDA
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:30 UTC 2023 for experiment C96_atm3DVar

@emcbot emcbot added CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels Jun 24, 2023
@emcbot
Copy link

emcbot commented Jun 24, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Fri Jun 23 19:24:18 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Fri Jun 23 19:26:15 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Fri Jun 23 20:42:34 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:40 CDT 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:44 CDT 2023 for experiment C96_atm3DVar
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:48 CDT 2023 for experiment C96C48_hybatmDA

@emcbot
Copy link

emcbot commented Jun 24, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Fri Jun 23 19:24:18 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Fri Jun 23 19:26:15 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Fri Jun 23 20:42:34 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:40 CDT 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:44 CDT 2023 for experiment C96_atm3DVar
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:48 CDT 2023 for experiment C96C48_hybatmDA
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Fri Jun 23 21:21:11 CDT 2023
with 18 successfully completed jobs

@emcbot
Copy link

emcbot commented Jun 24, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Sat Jun 24 00:24:58 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Sat Jun 24 00:30:23 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Sat Jun 24 01:36:20 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:24 UTC 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:27 UTC 2023 for experiment C96C48_hybatmDA
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:30 UTC 2023 for experiment C96_atm3DVar
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Sat Jun 24 03:42:16 UTC 2023
with 18 successfully completed jobs

@emcbot
Copy link

emcbot commented Jun 24, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Fri Jun 23 19:24:18 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Fri Jun 23 19:26:15 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Fri Jun 23 20:42:34 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:40 CDT 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:44 CDT 2023 for experiment C96_atm3DVar
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:48 CDT 2023 for experiment C96C48_hybatmDA
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Fri Jun 23 21:21:11 CDT 2023
with 18 successfully completed jobs
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Fri Jun 23 22:49:09 CDT 2023
with 73 successfully completed jobs

@emcbot
Copy link

emcbot commented Jun 24, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Sat Jun 24 00:24:58 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Sat Jun 24 00:30:23 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Sat Jun 24 01:36:20 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:24 UTC 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:27 UTC 2023 for experiment C96C48_hybatmDA
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:30 UTC 2023 for experiment C96_atm3DVar
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Sat Jun 24 03:42:16 UTC 2023
with 18 successfully completed jobs
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Sat Jun 24 06:56:08 UTC 2023
with 73 successfully completed jobs

@emcbot
Copy link

emcbot commented Jun 24, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Fri Jun 23 19:24:18 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Fri Jun 23 19:26:15 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Fri Jun 23 20:42:34 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:40 CDT 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:44 CDT 2023 for experiment C96_atm3DVar
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:48 CDT 2023 for experiment C96C48_hybatmDA
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Fri Jun 23 21:21:11 CDT 2023
with 18 successfully completed jobs
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Fri Jun 23 22:49:09 CDT 2023
with 73 successfully completed jobs
Experiment C96C48_hybatmDA completed: *SUCCESS*
Experiment C96C48_hybatmDA Completed at Sat Jun 24 02:21:07 CDT 2023
with 308 successfully completed jobs

@emcbot emcbot added CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Jun 24, 2023
@emcbot
Copy link

emcbot commented Jun 24, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Fri Jun 23 19:24:18 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Fri Jun 23 19:26:15 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Fri Jun 23 20:42:34 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:40 CDT 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:44 CDT 2023 for experiment C96_atm3DVar
Created experiment:            *SUCCESS*
Case setup: Completed at Fri Jun 23 20:42:48 CDT 2023 for experiment C96C48_hybatmDA
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Fri Jun 23 21:21:11 CDT 2023
with 18 successfully completed jobs
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Fri Jun 23 22:49:09 CDT 2023
with 73 successfully completed jobs
Experiment C96C48_hybatmDA completed: *SUCCESS*
Experiment C96C48_hybatmDA Completed at Sat Jun 24 02:21:07 CDT 2023
with 308 successfully completed jobs

@emcbot
Copy link

emcbot commented Jun 24, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Sat Jun 24 00:24:58 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Sat Jun 24 00:30:23 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Sat Jun 24 01:36:20 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:24 UTC 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:27 UTC 2023 for experiment C96C48_hybatmDA
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:30 UTC 2023 for experiment C96_atm3DVar
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Sat Jun 24 03:42:16 UTC 2023
with 18 successfully completed jobs
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Sat Jun 24 06:56:08 UTC 2023
with 73 successfully completed jobs
Experiment C96C48_hybatmDA completed: *SUCCESS*
Experiment C96C48_hybatmDA Completed at Sat Jun 24 09:56:07 UTC 2023
with 308 successfully completed jobs

@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jun 24, 2023
@emcbot
Copy link

emcbot commented Jun 24, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Sat Jun 24 00:24:58 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Sat Jun 24 00:30:23 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Sat Jun 24 01:36:20 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:24 UTC 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:27 UTC 2023 for experiment C96C48_hybatmDA
Created experiment:            *SUCCESS*
Case setup: Completed at Sat Jun 24 01:36:30 UTC 2023 for experiment C96_atm3DVar
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Sat Jun 24 03:42:16 UTC 2023
with 18 successfully completed jobs
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Sat Jun 24 06:56:08 UTC 2023
with 73 successfully completed jobs
Experiment C96C48_hybatmDA completed: *SUCCESS*
Experiment C96C48_hybatmDA Completed at Sat Jun 24 09:56:07 UTC 2023
with 308 successfully completed jobs

@jiandewang
Copy link
Contributor

@WalterKolczynski-NOAA I launched a test run last night, just checked it and can confirm that the fix works fine.

aerorahul
aerorahul approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aerorahul aerorahul merged commit 69946cf into NOAA-EMC:develop Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiandewang jiandewang jiandewang approved these changes

@aerorahul aerorahul aerorahul approved these changes

Assignees

@WalterKolczynski-NOAA WalterKolczynski-NOAA

Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing several hours of output in ocean post
4 participants
@WalterKolczynski-NOAA @emcbot @jiandewang @aerorahul