Add soil temperature and moisture IAU #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
tsga
force-pushed
the
feature/lnd_iau
branch
from
5e620d0 to
40e014f
Compare
|
Can't assign so tagging relevant people here. Please add (tag) anyone you think should be aware. |
Move DDTs to host
… feature/lnd_iau
… feature/lnd_iau * 'feature/lnd_iau' of https://github.com/tsga/fv3atm: default weight factors modify subroutines set/update increments combine DDTs holding increments; get rid of scheme level global array calculate snowsoil mask at runtime set land_iau_control from host
… feature/lnd_iau * 'feature/lnd_iau' of https://github.com/tsga/fv3atm: update noahmpdrv meta
… feature/lnd_iau
… feature/lnd_iau
* develop: Update chunksizes for cubed sphere grid (NOAA-EMC#876) First reconciliation PR from production/RRFS.v1 (NOAA-EMC#872)
* develop: Second reconciliation PR from production/RRFSv1 (NOAA-EMC#881) STY: Use capital W and lowercase m for watts per square meter (NOAA-EMC#859)
|
@tsga @jkbk2004 ufs-community/ccpp-physics#222 was merged. This branch is ready to point to the latest ufs/dev commit: ufs-community/ccpp-physics@cfa1861 and have .gitmodules reverted. |
jkbk2004
approved these changes
Nov 18, 2024
DusanJovic-NOAA
approved these changes
Nov 18, 2024
BrianCurtis-NOAA
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The atmospheric DA applies IAU increments on temperature (among other variables), while the land surface increments are applied once at the start of the DA (cycle?) window. This could lead to the land surface (soil and snow) temperature being out of sync with near surface atmospheric temperature
Issue(s) addressed
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Regression tests for ATM only and coupled (S2S) configurations pass in hera.
Additional land-IAU specific test to be added: control_c48_intel_land_iau (based on the "control_c48_intel" test, with the only difference being the turning on of land IAU and soil temperature increment files inside INPUT directory). The test inputs are at:
/scratch1/NCEPDEV/da/Tseganeh.Gichamo/ccpp-physics/test/control_c48_intel_land_iau
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs
Requirements before merging