-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to plot multiple logos or one #137
Conversation
This solution is good, though I do like the idea of an input="first", input="last", input="all". That seems a shade more flexible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@EdwardSafford-NOAA I agree with you. New commit has the option for more flexibility and will raise error if it is not one of those three inputs. I will attempt to debug the test failures tomorrow. |
Tests are failing @kevindougherty-noaa , any idea why? I echo, what you both think, it makes it clearer to be more explicit |
@kevindougherty-noaa is the error related to what was mentioned in EVA about matplotlib version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just had question on the commented lines in the yaml file.
This addresses issue #131 on EVA. A new option has been added to
plot_logos()
calledsingle_logo
. It is boolean and if True, it will only plot the logo on the final subplot of the figure.Example figures:
fig.plot_logo(loc='bottom right', single_logo=True, zoom=0.9, alpha=0.2)
fig.plot_logo(loc='bottom right', single_logo=False, zoom=0.9, alpha=0.2)
Please let me know if it would be a better idea to have the options be
str
such asinput="first"
,input="last"
,input="all"
.