Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to plot multiple logos or one #137

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

kevindougherty-noaa
Copy link
Contributor

This addresses issue #131 on EVA. A new option has been added to plot_logos() called single_logo. It is boolean and if True, it will only plot the logo on the final subplot of the figure.

Example figures:

fig.plot_logo(loc='bottom right', single_logo=True, zoom=0.9, alpha=0.2)

image

fig.plot_logo(loc='bottom right', single_logo=False, zoom=0.9, alpha=0.2)

image

Please let me know if it would be a better idea to have the options be str such as input="first", input="last", input="all".

@EdwardSafford-NOAA
Copy link
Contributor

This solution is good, though I do like the idea of an input="first", input="last", input="all". That seems a shade more flexible.

Copy link
Contributor

@EdwardSafford-NOAA EdwardSafford-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kevindougherty-noaa
Copy link
Contributor Author

@EdwardSafford-NOAA I agree with you. New commit has the option for more flexibility and will raise error if it is not one of those three inputs. I will attempt to debug the test failures tomorrow.

@CoryMartin-NOAA
Copy link
Contributor

Tests are failing @kevindougherty-noaa , any idea why? I echo, what you both think, it makes it clearer to be more explicit

@CoryMartin-NOAA
Copy link
Contributor

@kevindougherty-noaa is the error related to what was mentioned in EVA about matplotlib version?

Copy link
Contributor

@EdwardSafford-NOAA EdwardSafford-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had question on the commented lines in the yaml file.

.github/workflows/tests.yaml Show resolved Hide resolved
@CoryMartin-NOAA CoryMartin-NOAA merged commit 9b67563 into develop Jul 25, 2023
4 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/single_logos branch July 25, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants