Bug fix for blowing snow effect on visibility #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EricJames-NOAA Do you have an UPP issue to link this PR? |
@WenMeng-NOAA I had one but it got closed with my recent PR. I can open a new one if you like. |
@EricJames-NOAA Please open a new issue for the inventory of UPP updates. Thanks! |
|
@EricJames-NOAA Can you sync your branch with the latest UPP develop? |
|
@EricJames-NOAA Is your PR ready for reviewing and testing? If yes, please sync your branch with the latest UPP develop. |
|
@WenMeng-NOAA yes, this PR is ready for review! Thanks. I have just synced with the latest UPP develop branch. |
WenMeng-NOAA
added
the
Baseline Change
|
@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. Please refer to my tests on Hera at /home/Wen.Meng/stmp2: The actual values changes should be in variable "VIS". |
|
The UPP RTs have been completed on WCOSS2 with baseline changes in gfs, rap, hrrr, fv3r, nmmb, 3drtma tests. |
Hera and Hercules match your results, Orion however is running into segmentation faults within the hrrr_pe test |
|
@FernandoAndrade-NOAA My tests have been successfully completed on Orion at /home/wmeng/stmp2. I am not sure if there was a system issue during your testing. Or you can look into my test configurations /home/wmeng/ovp/ncep_post/post_regression_test_new/jobs and compare with your configurations. |
|
@FernandoAndrade-NOAA Since my UPP RTs on Orion are consistent with these on Hera and WCOSS2, we could merge this PR first, and you may debug the test failing later. Please let me know if this approach works for you. |
Sure thing, I'll compare our output and run scripts for the hrrr pe test case, I'll create an issue if the failure persists. Please expand read permissions for |
FernandoAndrade-NOAA
approved these changes
Apr 12, 2024
@FernandoAndrade-NOAA modified permission of /home/wmeng/ovp/ncep_post/post_regression_test_new. Please try again. |
WenMeng-NOAA
approved these changes
Apr 12, 2024
|
This PR is ready for merging. There will be baseline updates in gfs, nmmb, rap, hrrr, fv3r and 3drtma with this PR. |
zhanglikate
added a commit
to zhanglikate/UPP
that referenced
this pull request
Apr 30, 2024
commit 13d5b6d Author: EricJames-NOAA <[email protected]> Date: Mon Apr 29 15:28:47 2024 -0600 RRFS updates (NOAA-EMC#938) * Initial commit to rename RRFS fix files, update EBB to be vertically integrated from 3D ebu_smoke, and switch to use 1-h average HWP. * Getting rid of vertically integrated hydrometeor fields. * Updating postxconfig-NT-rrfs.txt commit 88493f3 Author: Wei Huang <[email protected]> Date: Fri Apr 26 21:29:51 2024 -0600 add module for AWS (NOAA-EMC#934) * add module for AWS * comment that this is for NOAA Cloud commit be0410e Author: hsinmulin-NOAA <[email protected]> Date: Tue Apr 23 15:46:47 2024 -0400 Add files via upload (NOAA-EMC#937) add 1. 80 m for SPFH_ON_SPEC_HGT_LVL_ABOVE_GRND_FDHGT 2. 80 m for PRES_ON_SPEC_HGT_LVL_ABOVE_GRND_FDHGT commit 79d74d9 Author: Edward Hartnett <[email protected]> Date: Mon Apr 22 13:34:39 2024 -0600 turn on doxygen build in CI (NOAA-EMC#932) * turn on doxygen build in CI * turn on doxygen build in CI * turn on doxygen build in CI * turn on doxygen build in CI * fixed cmake file * fixed doc directory commit 5d6d179 Author: Dusan Jovic <[email protected]> Date: Fri Apr 19 14:17:10 2024 -0400 Remove dependency on sfcio and use sigio only when nemsio is enabled (NOAA-EMC#930) * Remove sfcio and use sigio only when numsio is enabled * Remove sfcio from modulefiles/wcoss2.lua * Compile GFSPOSTSIG.F only if nemsio is enabled commit 91921f4 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Apr 15 21:04:39 2024 -0400 Bump idna from 3.6 to 3.7 in /doc/UserGuide (NOAA-EMC#928) Bumps [idna](https://github.com/kjd/idna) from 3.6 to 3.7. - [Release notes](https://github.com/kjd/idna/releases) - [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.rst) - [Commits](kjd/idna@v3.6...v3.7) --- updated-dependencies: - dependency-name: idna dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wen Meng <[email protected]> commit 8bc3fc9 Author: EricJames-NOAA <[email protected]> Date: Fri Apr 12 16:06:36 2024 -0600 Bug fix for blowing snow effect on visibility (NOAA-EMC#915) * Correcting bug in CALVIS_GSD.f * Introducing roughness length impact on BLSN (no BLSN effect at z0>0.7). * Removing some gridpoint print statements for testing. * Checking change to compile_upp.sh * Reverting change. commit fd93933 Author: YaliMao-NOAA <[email protected]> Date: Thu Apr 11 17:14:24 2024 +0000 For RRFS, change the mnemonics of column max of EDPARM from EDPARM on 0m level to MXEDPRM of the entire atmosphere. (NOAA-EMC#926) For this purpose, MXEDPRM is added to both post_avblflds.xml and control file fv3lam_rrfs.xml commit 5faac75 Author: WenMeng-NOAA <[email protected]> Date: Tue Apr 9 18:25:18 2024 -0400 Correct total soil moisture from SOIMOI to CISOIM (NOAA-EMC#922) * Correct total soil moisture from SOIMOI to CISOIM * Update shortname of UPP ID 36 * update CMake debug mode commit 83e83a9 Author: Innocent Souopgui <[email protected]> Date: Fri Apr 5 15:10:14 2024 -0500 Remove the detection of Jet/Centos7 nodes (NOAA-EMC#920) * Remove the detection of Jet/Centos7 nodes and removes the associated module file jet_c.lua * Update detect_machine.sh remove hera 12 --------- Co-authored-by: Fernando Andrade - NOAA <[email protected]> commit 1d1e58a Author: Dusan Jovic <[email protected]> Date: Fri Apr 5 13:10:20 2024 -0400 Add BUILD_WITH_NEMSIO build option to allow building UPP without nemsio (NOAA-EMC#911) * Add BUILD_WITH_NEMSIO build option to allow building UPP without nemsio * Specify w3emc and bacio as dependencies of nemsio library * Add compile_upp.sh option to build without nemsio (-n) commit 7d39b5c Author: WenMeng-NOAA <[email protected]> Date: Thu Apr 4 17:07:14 2024 -0400 Add LTNG in PRSLEV dataset of RRFS (NOAA-EMC#918) commit 62ecf8a Author: AndrewBenjamin-NOAA <[email protected]> Date: Thu Apr 4 14:50:08 2024 -0400 RRFSv1.0 Product cleanup: removal of retired products from fv3lam_rrfs.xml (NOAA-EMC#909) * removed <table_info>NCEP</table_info> for ULWRF to use the official WMO ID rather than the dupilcate NCEP local use ID * removed <table_info>NCEP</table_info> from REFZR, REFZI, BMIXL, and CNWAT to use WMO grib2 ids * removed <table_info>NCEP</table_info> from SNOWC, SFEXC, SSRUN, BGRUN, FRICV, CD, SNOHF, PEVAP, TCOLI in order to use WMO id over NCEP local use ID. * removed <table_info>NCEP<table_info> from SNFALB, CDLYR, USWRF, DSWRF, DLWRF, VWSH, TCOLR, TCOLS, UPHL * removed <table_info>NCEP<table_info> from MSTAV in post_avblflds.xml to use WMO grib2 id for RRFS * removed duplicate CNWAT NATLEV entry in fv3lam_rrfs.xml. * updated fv3lam_rrfs.xml and parm/postxconfig-NT-fv3lam_rrfs.txt to remove products no longer needed in the RRFS. * changed precision in SSRUN * fixed SSRUN precision in flat file * removed LSPA and SNOWC from NATLEV commit df9b16b Author: EricJames-NOAA <[email protected]> Date: Mon Apr 1 15:51:56 2024 -0600 Add surface albedo, accumulated snow melt, and total soil moisture output in RRFS (NOAA-EMC#908) * Updating CLDRAD and INITPOST_NETCDF * Reverting change in CLDRAD.f * Changes to output CISOILM and SNOM. * Cleaning up syntax. * Adding change logs. * Small updates. * Removing extcof55 from visibility calculation (it's all zeroes). * Reverting change in INITPOST_NETCDF.f setting smstot to spval * Using a single level "0 m underground" for CISOILM commit 92b080d Author: KarinaAsmar-NOAA <[email protected]> Date: Sat Mar 30 20:03:49 2024 -0400 Add additional SFS variables and isobaric levels (NOAA-EMC#903) * added additional isobaric levels * adding HLCY, SSRUN, VBDSF * added HLCY, SSRUN, VBDSF * replacing id 772 with 401 and 403 (vbdsf and nbdsf) * vbdsf and nbdsf with info from avblflds * removed id 772 and added 401 and 403 (vbdsf and nbdsf) * vbdsf and nbdsf copied from gfs flux * vbdsf and nbdsf copied from gfs flux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOAA AWC noted a pronounced low bias in visibility in RRFS-A during the beta evaluation. We confirmed it is due to the blowing snow effect.
This PR restricts the blowing snow effect on visibility to roughness length (z0) < 0.7 (non-forested areas). With this new code, there will be no blowing snow effect in forested areas.
The bug fix also corrects the BLSN formulation (there was a missing factor of ustar_t in the equation for Q_s).
The code was tested for a number of blowing snow cases in RRFS_NA_3km and RRFS_CONUS_3km.