Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UPP for rocky8 transition on Hera and Jet #895

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

WenMeng-NOAA
Copy link
Collaborator

Update UPP for rocky8 transition on Hera and Jet.

@FernandoAndrade-NOAA
Copy link
Collaborator

Hi @WenMeng-NOAA, I had no changed results after making similar changes and running RTs/compile for Hera and Jet on Thursday/Friday. Would you like me to rerun for this PR when it's ready or would that pretesting be sufficient?

@WenMeng-NOAA
Copy link
Collaborator Author

Hi @WenMeng-NOAA, I had no changed results after making similar changes and running RTs/compile for Hera and Jet on Thursday/Friday. Would you like me to rerun for this PR when it's ready or would that pretesting be sufficient?

@FernandoAndrade-NOAA Your pre-testing on Hera should be sufficient. Please let me know if you have more comments.

@WenMeng-NOAA WenMeng-NOAA added enhancement New feature or request Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. labels Mar 18, 2024
@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA The building (compiling) test on Jet was successful.

@FernandoAndrade-NOAA
Copy link
Collaborator

Hi @WenMeng-NOAA, I had no changed results after making similar changes and running RTs/compile for Hera and Jet on Thursday/Friday. Would you like me to rerun for this PR when it's ready or would that pretesting be sufficient?

@FernandoAndrade-NOAA Your pre-testing on Hera should be sufficient. Please let me know if you have more comments.

Sounds good, thanks! I'll go ahead and start up RTs on Orion and Hercules

@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RTs were completed on WCOSS2 without changed results.

@WenMeng-NOAA WenMeng-NOAA linked an issue Mar 18, 2024 that may be closed by this pull request
Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will a lot of developers/users still be working on CentOS between now and April 2nd on Hera? Would it make more sense to transition entirely to Rocky 8 so an additional PR is not required after the upgrade?

I'm not sure when Jet and kjet will be upgraded, but it should not be much longer after that, so the same question applies there.

@WenMeng-NOAA
Copy link
Collaborator Author

Will a lot of developers/users still be working on CentOS between now and April 2nd on Hera? Would it make more sense to transition entirely to Rocky 8 so an additional PR is not required after the upgrade?

I'm not sure when Jet and kjet will be upgraded, but it should not be much longer after that, so the same question applies there.

@DavidHuber-NOAA The modulefiles jet_c.lua and hera_c.lua are for CentOS 7 nodes on Jet and Hera.

@DavidHuber-NOAA
Copy link
Collaborator

@WenMeng-NOAA Yes, I see that, but my question is if those really need to be included. Since CentOS will only be available for another two weeks, does the UPP really need to support CentOS during that period?

If the answer is yes, then I should point out that in two weeks, the build script will attempt to compile using hera_c modules when logged into nodes hfe01 through hfe08, which will fail. Thus, a new UPP PR will need to be written soon and all downstream applications will need to pick it up.

@WenMeng-NOAA
Copy link
Collaborator Author

@WenMeng-NOAA Yes, I see that, but my question is if those really need to be included. Since CentOS will only be available for another two weeks, does the UPP really need to support CentOS during that period?

If the answer is yes, then I should point out that in two weeks, the build script will attempt to compile using hera_c modules when logged into nodes hfe01 through hfe08, which will fail. Thus, a new UPP PR will need to be written soon and all downstream applications will need to pick it up.

@DavidHuber-NOAA The hera_c and jet_c are workaround for our UPP developers from GFS and RRFS during rocky8 transition period. GSL has been running RRFS parallel on Jet. When rocky8 transition on Hera is completed, I will update UPP for all rocky8 configuration.

@DavidHuber-NOAA
Copy link
Collaborator

Alright, that sounds good then.

Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules point where they should. Approve.

@WenMeng-NOAA
Copy link
Collaborator Author

@DavidHuber-NOAA I will update upp revision at ufs-weather-model after rocky8 transition is done on Hera.

Copy link
Collaborator

@FernandoAndrade-NOAA FernandoAndrade-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hercules and Orion RTs have completed successfully with no changes to results. Hera RTs during earlier testing on Rocky 8 showed no changes. Jet build on Rocky 8 did not run into any issues.

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 15e2a8c into NOAA-EMC:develop Mar 18, 2024
5 checks passed
@WenMeng-NOAA WenMeng-NOAA deleted the post_rocky8 branch June 21, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile with Rocky 8 OS
3 participants