Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UPP for GFS V17 HR4 #894

Merged
merged 10 commits into from
Mar 22, 2024
Merged

Conversation

WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA WenMeng-NOAA commented Mar 17, 2024

The main updates are:

  • Remove ICETMP and ICEG
  • Remove time averaged P-types
  • option for reading 3D soil fields

@WenMeng-NOAA WenMeng-NOAA added GFSV17 Ready for Review This PR is ready for code review. Baseline Change The baselines of the UPP regression tests are changed. labels Mar 19, 2024
@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RTs were completed on WCOSS2. The changes will be in gfs baseline only. The following fields will be removed from GFS master and related pgrb2/pgrb2b files:

CSNOW:surface:0-6 hour ave fcst:
CRAIN:surface:0-6 hour ave fcst:
CICEP:surface:0-6 hour ave fcst:
CFRZR:surface:0-6 hour ave fcst:
VVEL:?? mb
VVEL:0.995 sigma level
ICETMP:surface
ICEG:10 m above mean sea level

The total fields in master file is 1045.

@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA This PR is ready for testing on Hera and Orion.

@FernandoAndrade-NOAA
Copy link
Collaborator

The UPP RTs were completed on WCOSS2. The changes will be in gfs baseline only. The following fields will be removed from GFS master and related pgrb2/pgrb2b files:

CSNOW:surface:0-6 hour ave fcst:
CRAIN:surface:0-6 hour ave fcst:
CICEP:surface:0-6 hour ave fcst:
CFRZR:surface:0-6 hour ave fcst:
VVEL:?? mb
VVEL:0.995 sigma level
ICETMP:surface
ICEG:10 m above mean sea level

The total fields in master file is 1045.

Hera, Hercules, and Orion RTs match with your results.

@WenMeng-NOAA WenMeng-NOAA added On hold and removed Ready for Review This PR is ready for code review. labels Mar 20, 2024
@WenMeng-NOAA
Copy link
Collaborator Author

@junwang-noaa @HuiyaChuang-NOAA Following our discussion, VVEL products have been retained in the HR4 product list. Removal will be addressed later.

@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA This PR is ready for testing. You may refer my tests on Hera at /home/Wen.Meng/stmp2:

[Wen.Meng@hfe11 stmp2]$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp    75 Mar 21 23:54 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp 21144 Mar 22 00:07 gfs.20190830/gfs.t00z.master.grb2f006.diff
-rw-r--r-- 1 Wen.Meng stmp 21144 Mar 22 00:08 gfs.20190830_pe_test/gfs.t00z.master.grb2f006.diff

The GFS master file is changed from 1109 fields to 1103 fields.

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA This PR is ready for testing. You may refer my tests on Hera at /home/Wen.Meng/stmp2:

[Wen.Meng@hfe11 stmp2]$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp    75 Mar 21 23:54 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp 21144 Mar 22 00:07 gfs.20190830/gfs.t00z.master.grb2f006.diff
-rw-r--r-- 1 Wen.Meng stmp 21144 Mar 22 00:08 gfs.20190830_pe_test/gfs.t00z.master.grb2f006.diff

The GFS master file is changed from 1109 fields to 1103 fields.

RTs on Hera, Hercules, and Orion are showing the same results.

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit e2189f7 into NOAA-EMC:develop Mar 22, 2024
5 checks passed
@WenMeng-NOAA WenMeng-NOAA deleted the post_HR4 branch June 21, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Change The baselines of the UPP regression tests are changed. GFSV17
Projects
None yet
3 participants