Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync EE2 updates from AQM v7 implementation #890

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Sync EE2 updates from AQM v7 implementation #890

merged 5 commits into from
Mar 13, 2024

Conversation

WenMeng-NOAA
Copy link
Collaborator

The main updates are:

  • Sync EE2 updates from AQM v7 implementation
  • Upgrade crtm to 2.4.0.1 on WCOSS2
  • Update modulefiles on WCOSS2 Acorn

This was linked to issues Mar 11, 2024
Sync changes of AQM v7 to UPP develop #882
Closed
Update UPP with crtm/2.4.0.1 on WCOSS2 and WCOSS2_Acorn #881
Closed
@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA This PR is ready for testing on Hera and Orion. Thanks!

@WenMeng-NOAA WenMeng-NOAA added enhancement New feature or request Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. labels Mar 13, 2024
@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RTs were completed on WCOSS2 without changed results.

FernandoAndrade-NOAA
FernandoAndrade-NOAA approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@FernandoAndrade-NOAA FernandoAndrade-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPP RTs on Hera, Hercules, and Orion have completed successfully with no changes to results.

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit d597055 into NOAA-EMC:develop Mar 13, 2024
5 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync changes of AQM v7 to UPP develop Update UPP with crtm/2.4.0.1 on WCOSS2 and WCOSS2_Acorn
2 participants
@WenMeng-NOAA @FernandoAndrade-NOAA