Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RRFS: Use the 10-m wind gust calculation from RAP / HRRR #876

Merged
merged 10 commits into from
Mar 1, 2024
Merged

RRFS: Use the 10-m wind gust calculation from RAP / HRRR #876

merged 10 commits into from
Mar 1, 2024

Conversation

jaymes-kenyon
Copy link
Contributor

@jaymes-kenyon jaymes-kenyon commented Feb 20, 2024 •
edited
Loading

This addresses issue #874.

For RRFS applications, the 10-m wind gust calculation is updated to use a PBL height that is diagnosed from the theta-v profile, rather than the Ri profile. This makes the RRFS wind-gust diagnostic almost identical to that used in RAP / HRRR.

Note that this internal PBL height calculation is used only for diagnosing the 10-m wind gust; i.e., this PBL height is independent of the PBL height that is calculated within the model itself (MYNN scheme).

Lastly, note that horizontal smoothing of the intermediate "PBLHGUST" array (in MDLFLD.f) is not applied in RRFS applications. Smoothing of this array (subsequently used in the gust calculation) was done in RAP / HRRR applications. In this sense, the proposed RRFS gust diagnostic does not strictly follow the RAP / HRRR formulation.

Testing results are shown in the comments below. Copying @joeolson42 and @EricJames-NOAA for their awareness.

@FernandoAndrade-NOAA FernandoAndrade-NOAA linked an issue Feb 20, 2024 that may be closed by this pull request
RRFS: Use the 10-m wind gust diagnostic from RAP/HRRR #874
Closed
@jaymes-kenyon
Copy link
Contributor Author

jaymes-kenyon commented Feb 21, 2024 •
edited
Loading

This update was tested successfully in a RRFS case (CONUS domain) on Hera. The figure below shows the 10-m wind gust using the original/current diagnostic (left), and the proposed/updated diagnostic (right); both panels are for 12-h forecasts initialized at 00 UTC 2 Feb 2022.

gust_compared

The difference field for these panels (updated minus original) is shown below. In this case, the proposed code almost always yields a reduced 10-m gust.

new_minus_orig

For synoptic context, the surface analysis for 1200 UTC 2 Feb 2022 is shown below. Comparison with the difference field suggests that the largest wind-gust reductions have occurred east of the cold front across the eastern CONUS.

namussfc2022020212

@jaymes-kenyon jaymes-kenyon marked this pull request as ready for review February 21, 2024 20:23
@JacobCarley-NOAA
Copy link

@jaymes-kenyon thanks so much for the quick turnaround on this!

One quick item - I recommend turning off the smoothing. A couple years ago we reviewed the smoothing that was applied in RAP/HRRR and elected not to apply the smoothing for RRFS. Would you mind turning it off?

@yangfanglin
Copy link

If the new method verifies better with observations, can it be applied to all UFS applications ? Can someone run a few tests using HAFS, GFS and GEFS forecasts ?

@jaymes-kenyon
Copy link
Contributor Author

@jaymes-kenyon thanks so much for the quick turnaround on this!

One quick item - I recommend turning off the smoothing. A couple years ago we reviewed the smoothing that was applied in RAP/HRRR and elected not to apply the smoothing for RRFS. Would you mind turning it off?

Thanks, @JacobCarley-NOAA. I disabled the smoothing of the PBLHGUST array in the latest commit. The resulting differences are mostly small and noisy (see below; no_smooth minus smooth), but some coastal areas show more appreciable differences. Thanks again! diff_nosmooth

@JacobCarley-NOAA
Copy link

@jaymes-kenyon thanks so much for the quick turnaround on this!
One quick item - I recommend turning off the smoothing. A couple years ago we reviewed the smoothing that was applied in RAP/HRRR and elected not to apply the smoothing for RRFS. Would you mind turning it off?

Thanks, @JacobCarley-NOAA. I disabled the smoothing of the PBLHGUST array in the latest commit. The resulting differences are mostly small and noisy (see below; no_smooth minus smooth), but some coastal areas show more appreciable differences. Thanks again! diff_nosmooth

Thanks @jaymes-kenyon this looks good!

HuiyaChuang-NOAA
HuiyaChuang-NOAA approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@HuiyaChuang-NOAA HuiyaChuang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaymes-kenyon thank you for working on this

@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon Please sync your branch with the latest UPP develop.

@jaymes-kenyon jaymes-kenyon marked this pull request as draft February 28, 2024 15:58
@WenMeng-NOAA
Copy link
Collaborator

@jaymes-kenyon It seems to me that your branch wasn't synced in right way. Some changes from merged PRs are added.

@jaymes-kenyon
Copy link
Contributor Author

@WenMeng-NOAA — I had some difficulty getting my branch synched with EMC/develop, but I think the PR is ready now.

@jaymes-kenyon jaymes-kenyon marked this pull request as ready for review February 28, 2024 18:46
@WenMeng-NOAA WenMeng-NOAA added Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. labels Feb 29, 2024
@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. For your reference, my RT results on Hera at /scratch1/NCEPDEV/stmp2/Wen.Meng as:

[Wen.Meng@hfe04 ~/stmp2]$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp    58 Feb 29 12:44 fv3hafs_2022092800/HURPRS09.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp    58 Feb 29 12:45 fv3hafs_2022092800_pe_test/HURPRS09.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp    75 Feb 29 12:45 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp  2010 Feb 29 12:46 fv3r_2023062800/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2010 Feb 29 12:47 fv3r_2023062800_pe_test/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14810 Feb 29 12:47 rtma_2023040400_pe_test/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14810 Feb 29 12:48 rtma_2023040400/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14656 Feb 29 12:49 fv3r_2023062800/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2575 Feb 29 12:49 rtma_2023040400_pe_test/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14656 Feb 29 12:49 fv3r_2023062800_pe_test/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2575 Feb 29 12:49 rtma_2023040400/PRSLEV00.tm00.diff

The changes are on GUEST field for fv3r, 3drtma and hafs.

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. For your reference, my RT results on Hera at /scratch1/NCEPDEV/stmp2/Wen.Meng as:

[Wen.Meng@hfe04 ~/stmp2]$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp    58 Feb 29 12:44 fv3hafs_2022092800/HURPRS09.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp    58 Feb 29 12:45 fv3hafs_2022092800_pe_test/HURPRS09.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp    75 Feb 29 12:45 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp  2010 Feb 29 12:46 fv3r_2023062800/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2010 Feb 29 12:47 fv3r_2023062800_pe_test/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14810 Feb 29 12:47 rtma_2023040400_pe_test/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14810 Feb 29 12:48 rtma_2023040400/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14656 Feb 29 12:49 fv3r_2023062800/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2575 Feb 29 12:49 rtma_2023040400_pe_test/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14656 Feb 29 12:49 fv3r_2023062800_pe_test/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2575 Feb 29 12:49 rtma_2023040400/PRSLEV00.tm00.diff

The changes are on GUEST field for fv3r, 3drtma and hafs.

My RT results on Hera and Orion are consistent with yours, looks good!

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 10bfc06 into NOAA-EMC:develop Mar 1, 2024
5 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Mar 1, 2024
Closed
@jaymes-kenyon jaymes-kenyon deleted the rrfs_10m_gust branch March 1, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

@HuiyaChuang-NOAA HuiyaChuang-NOAA HuiyaChuang-NOAA approved these changes

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

Assignees
No one assigned
Labels
Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RRFS: Use the 10-m wind gust diagnostic from RAP/HRRR
6 participants
@jaymes-kenyon @JacobCarley-NOAA @yangfanglin @WenMeng-NOAA @FernandoAndrade-NOAA @HuiyaChuang-NOAA