Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out graupel warning #865

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Comment out graupel warning #865

merged 2 commits into from
Jan 31, 2024

Conversation

AndersJensen-NOAA
Copy link
Contributor

@AndersJensen-NOAA AndersJensen-NOAA commented Jan 30, 2024 •
edited by WenMeng-NOAA
Loading

This PR fixes issue #866

@FernandoAndrade-NOAA
Copy link
Collaborator

FernandoAndrade-NOAA commented Jan 30, 2024 •
edited
Loading

Hi @AndersJensen-NOAA, please link/create a git issue and add a description to the PR description itself. Changes to /sorc files will also need a changelog addition in the beginning section before approval, thank you! This helps with managing and tracking of updates.

@WenMeng-NOAA
Copy link
Collaborator

@AndersJensen-NOAA Per UPP code contribution procedure (here), please open an UPP issue with a brief description of the issue you are addressing at https://github.com/NOAA-EMC/UPP/issues. Thanks!

@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs were completed on WCOSS2 without changed results.

@AndersJensen-NOAA
Copy link
Contributor Author

This PR fixes issue #866

@WenMeng-NOAA WenMeng-NOAA linked an issue Jan 31, 2024 that may be closed by this pull request
Graupel precipitation warning print statement #866
Closed
@WenMeng-NOAA WenMeng-NOAA added No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. labels Jan 31, 2024
@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There should be no baseline update with this PR.

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There should be no baseline update with this PR.

Hera and Orion UPP RTs completed without changes to results. Looks good on my side!

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 2894699 into NOAA-EMC:develop Jan 31, 2024
4 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanyasmirnova tanyasmirnova tanyasmirnova approved these changes

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

Assignees
No one assigned
Labels
No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graupel precipitation warning print statement
4 participants
@AndersJensen-NOAA @FernandoAndrade-NOAA @WenMeng-NOAA @tanyasmirnova