Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins RT Improvements #837

Merged
merged 83 commits into from
Dec 8, 2023

Conversation

FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA FernandoAndrade-NOAA commented Dec 7, 2023

This PR introduces additional functionality to clearly display UPP regression test results on the relevant PR once initial review has been completed and the appropriate label has been added to the PR. Jenkins will now leave comments summarizing RT results on head machine. Jenkins currently runs on Hera, Orion, and with this PR, Hercules as well. Failures will be accompanied with the run directory in order to verify changes in results or diagnose issues.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added the enhancement New feature or request label Dec 7, 2023
@FernandoAndrade-NOAA
Copy link
Collaborator Author

The parm/ changes were for testing purposes, it will be reverted to sync up with develop.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA Do you have an UPP issue linking to this PR? Please sync parm/fv3lam_rrf in your branch with the UPP develop branch.

@FernandoAndrade-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA Do you have an UPP issue linking to this PR? Please sync parm/fv3lam_rrf in your branch with the UPP develop branch.

Issue created and linked, I've also reverted the rrfs dummy changes used in testing, they should match develop now.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA Can you sync your branch with the latest UPP develop branch?

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. labels Dec 8, 2023
@FernandoAndrade-NOAA FernandoAndrade-NOAA marked this pull request as ready for review December 8, 2023 15:58
@FernandoAndrade-NOAA
Copy link
Collaborator Author

PR was synced and taken out of draft

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RT on Hera and Orion. Thanks!

@FernandoAndrade-NOAA
Copy link
Collaborator Author

Jenkins as of this morning is having issues connecting to the Tier1 systems and the platform team is working with system admins to get that resolved, I'll be running manually.

From a meeting discussion earlier, the degradation in performance on my side for Hera may potentially be caused by a significantly lower allocation this month for Hera specifically. Orion seems to be running fine and Hercules I'm still trying to get to fully complete RT runs. It seems at this time I will only be able to run tests for Orion while issues for the other two are resolved.

@FernandoAndrade-NOAA
Copy link
Collaborator Author

No changes in Orion UPP RTs available here:
/work2/noaa/epic/nandoam/regression-testing/upp/orion/837/UPP/ci/rundir/upp-ORION

@FernandoAndrade-NOAA
Copy link
Collaborator Author

@WenMeng-NOAA if you could confirm your RTs were successful for Hera, could you provide a run directory? I can update the epic baselines on Hera with your files if you aren't running into any issues with your RT runs.

@WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA if you could confirm your RTs were successful for Hera, could you provide a run directory? I can update the epic baselines on Hera with your files if you aren't running into any issues with your RT runs.

@FernandoAndrade-NOAA Please see my baselines of the UPP RT at /scratch2/NCEPDEV/ovp/Wen.Meng/ncep_post/post_regression_test_new/data_out. The run directories of this PR testing are at /scratch1/NCEPDEV/stmp2/Wen.Meng

@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs were completed on WCOSS2 and Hera without changed results. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 40b7dbd into NOAA-EMC:develop Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to the Jenkins RT Pipeline
3 participants