Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed warnings #779

Merged
merged 7 commits into from
Dec 18, 2024
Merged

fixed warnings #779

merged 7 commits into from
Dec 18, 2024

Conversation

edwardhartnett
Copy link
Contributor

Fixes #778

@edwardhartnett edwardhartnett marked this pull request as ready for review December 16, 2024 14:32
Hang-Lei-NOAA
Hang-Lei-NOAA approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Hang-Lei-NOAA Hang-Lei-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of functions in g2 was for old global spectral model (GSM) with spherical harmonic basis functions. As I refer to the developer, these will not be used in the future,

@edwardhartnett edwardhartnett merged commit f38095a into develop Dec 18, 2024
72 checks passed
@edwardhartnett edwardhartnett deleted the ejh_warn1 branch December 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hang-Lei-NOAA Hang-Lei-NOAA Hang-Lei-NOAA approved these changes

@AlysonStahl-NOAA AlysonStahl-NOAA Awaiting requested review from AlysonStahl-NOAA

@AlexanderRichert-NOAA AlexanderRichert-NOAA Awaiting requested review from AlexanderRichert-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

code warnings in test code and copygb2 unused variables
2 participants
@edwardhartnett @Hang-Lei-NOAA