Add 7777 test #668
Merged
Add 7777 test #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commented out do-loop so test will pass CI and can be merged before further work.
edwardhartnett
approved these changes
May 12, 2024
Free memory to pass memcheck in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unit test for
getgb2p()based on the newly added RRFS t12z awips file. This is the file that we have been having problems with processing with tocgrib2, including the 7777 issue.Currently, on my personal machine, the test fails with a segfault. Not too surprisingly, the segfault goes away if I comment out the lines where the '7777' octets are added in
getgb2rp2(), once again pointing to issues with the indexing for some messages.Related to #666