Skip to content

Commit

Permalink
remove untestable bort cases from nemtbb and nemtbd
Browse files Browse the repository at this point in the history
  • Loading branch information
jbathegit committed Nov 22, 2023
1 parent 1b71c96 commit 4d5449c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 41 deletions.
17 changes: 0 additions & 17 deletions src/nemtbb.f
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,6 @@ SUBROUTINE NEMTBB(LUN,ITAB,UNIT,ISCL,IREF,IBIT)
C CHECK TABLE B CONTENTS
C ----------------------

IF(IDN.LT.IFXY('000000')) GOTO 901
IF(IDN.GT.IFXY('063255')) GOTO 901

IF(ISCL.LT.-999 .OR. ISCL.GT.999) GOTO 902
IF(IREF.LE.-MXR .OR. IREF.GE.MXR) GOTO 903
IF(IBIT.LE.0) GOTO 904
IF(UNIT(1:5).NE.'CCITT' .AND. IBIT.GT.32 ) GOTO 904
IF(UNIT(1:5).EQ.'CCITT' .AND. MOD(IBIT,8).NE.0) GOTO 905
Expand All @@ -61,18 +56,6 @@ SUBROUTINE NEMTBB(LUN,ITAB,UNIT,ISCL,IREF,IBIT)
900 WRITE(BORT_STR,'("BUFRLIB: NEMTBB - ITAB (",I7,") NOT FOUND IN '//
. 'TABLE B")') ITAB
CALL BORT(BORT_STR)
901 WRITE(BORT_STR,'("BUFRLIB: NEMTBB - INTEGER REPRESENTATION OF '//
. 'DESCRIPTOR FOR TABLE B MNEMONIC ",A," (",I7,") IS OUTSIDE '//
. 'RANGE 0-16383 (16383 -> 0-63-255)")') NEMO,IDN
CALL BORT(BORT_STR)
902 WRITE(BORT_STR,'("BUFRLIB: NEMTBB - SCALE VALUE FOR TABLE B '//
.'MNEMONIC ",A," (",I7,") IS OUTSIDE RANGE -999 TO 999")')
. NEMO,ISCL
CALL BORT(BORT_STR)
903 WRITE(BORT_STR,'("BUFRLIB: NEMTBB - REFERENCE VALUE FOR TABLE B'//
.' MNEMONIC ",A," (",I7,") IS OUTSIDE RANGE +/- 1E11-1")')
. NEMO,IREF
CALL BORT(BORT_STR)
904 WRITE(BORT_STR,'("BUFRLIB: NEMTBB - BIT WIDTH FOR NON-CHARACTER'//
. ' TABLE B MNEMONIC ",A," (",I7,") IS > 32")') NEMO,IBIT
CALL BORT(BORT_STR)
Expand Down
24 changes: 0 additions & 24 deletions src/nemtbd.f
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,12 @@ SUBROUTINE NEMTBD(LUN,ITAB,NSEQ,NEMS,IRPS,KNTS)
CHARACTER*6 ADN30,CLEMON
CHARACTER*1 TAB
DIMENSION NEMS(*),IRPS(*),KNTS(*)
LOGICAL REP

C-----------------------------------------------------------------------
C-----------------------------------------------------------------------

IF(ITAB.LE.0 .OR. ITAB.GT.NTBD(LUN)) GOTO 900

REP = .FALSE.

C CLEAR THE RETURN VALUES
C -----------------------

Expand All @@ -76,9 +73,6 @@ SUBROUTINE NEMTBD(LUN,ITAB,NSEQ,NEMS,IRPS,KNTS)
IDSC = IDND(ITAB,LUN)
CALL UPTDD(ITAB,LUN,0,NDSC)

IF(IDSC.LT.IFXY('300000')) GOTO 901
IF(IDSC.GT.IFXY('363255')) GOTO 901

C Loop through each child mnemonic.

c .... DK: What happens here if NDSC=0 ?
Expand All @@ -88,8 +82,6 @@ SUBROUTINE NEMTBD(LUN,ITAB,NSEQ,NEMS,IRPS,KNTS)
c .... get NEMT from IDSC
CALL NUMTAB(LUN,IDSC,NEMT,TAB,IRET)
IF(TAB.EQ.'R') THEN
IF(REP) GOTO 904
REP = .TRUE.
IF(IRET.LT.0) THEN

C F=1 regular (i.e. non-delayed) replication.
Expand All @@ -106,15 +98,11 @@ SUBROUTINE NEMTBD(LUN,ITAB,NSEQ,NEMS,IRPS,KNTS)

C Replication factor.

IF(.NOT.REP) GOTO 904
IRPS(NSEQ+1) = IRET
REP = .FALSE.
ELSEIF(TAB.EQ.'D'.OR.TAB.EQ.'C') THEN
REP = .FALSE.
NSEQ = NSEQ+1
NEMS(NSEQ) = NEMT
ELSEIF(TAB.EQ.'B') THEN
REP = .FALSE.
NSEQ = NSEQ+1
IF((NEMT(1:1).EQ.'.').AND.(J.LT.NDSC)) THEN

Expand All @@ -124,7 +112,6 @@ SUBROUTINE NEMTBD(LUN,ITAB,NSEQ,NEMS,IRPS,KNTS)
c .... get NEMF from IDSC
CALL NUMTAB(LUN,IDSC,NEMF,TAB,IRET)
CALL RSVFVM(NEMT,NEMF)
IF(TAB.NE.'B') GOTO 906
ENDIF
NEMS(NSEQ) = NEMT
ELSE
Expand All @@ -139,23 +126,12 @@ SUBROUTINE NEMTBD(LUN,ITAB,NSEQ,NEMS,IRPS,KNTS)
900 WRITE(BORT_STR,'("BUFRLIB: NEMTBD - ITAB (",I7,") NOT FOUND IN '//
. 'TABLE D")') ITAB
CALL BORT(BORT_STR)
901 WRITE(BORT_STR,'("BUFRLIB: NEMTBD - INTEGER REPRESENTATION OF '//
. 'DESCRIPTOR FOR TABLE D MNEMONIC ",A," (",I7,") IS OUTSIDE '//
. 'RANGE 0-65535 (65535 -> 3-63-255)")') NEMO,IDSC
CALL BORT(BORT_STR)
903 WRITE(BORT_STR,'("BUFRLIB: NEMTBD - THERE ARE MORE THAN '//
. '(",I4,") DESCRIPTORS (THE LIMIT) IN TABLE D SEQUENCE '//
. 'MNEMONIC ",A)') MAXCD, NEMO
CALL BORT(BORT_STR)
904 WRITE(BORT_STR,'("BUFRLIB: NEMTBD - REPLICATOR IS OUT OF ORDER '//
. 'IN TABLE D SEQUENCE MNEMONIC ",A)') NEMO
CALL BORT(BORT_STR)
905 CLEMON = ADN30(IDSC,6)
WRITE(BORT_STR,'("BUFRLIB: NEMTBD - UNRECOGNIZED DESCRIPTOR '//
. '",A," IN TABLE D SEQUENCE MNEMONIC ",A)') CLEMON,NEMO
CALL BORT(BORT_STR)
906 WRITE(BORT_STR,'("BUFRLIB: NEMTBD - A ''FOLLOWING VALUE'' '//
. 'MNEMONIC (",A,") IS FROM TABLE ",A,", IT MUST BE FROM TABLE B'//
. '")') NEMF,TAB
CALL BORT(BORT_STR)
END

0 comments on commit 4d5449c

Please sign in to comment.