Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update orion modulefile for Rocky 8 #47

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Jun 28, 2024

What the title says ...

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@RussTreadon-NOAA
Copy link
Contributor

We have no GSI-utils ctests. I am reluctant to review and approve untested changes. In my opinion PRs are incomplete without testing.

I approved this PR because an approval is required to merge. Please invite others to review GSI-utils PRs.

@aerorahul
Copy link
Contributor Author

Thanks for your review.

@aerorahul
Copy link
Contributor Author

@RussTreadon-NOAA
Needs an actual GH approval. The green check mark.

@RussTreadon-NOAA RussTreadon-NOAA self-requested a review June 28, 2024 19:58
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@aerorahul aerorahul merged commit 9382fd0 into develop Jun 28, 2024
4 checks passed
@aerorahul aerorahul deleted the feature/orion-rocky8 branch June 28, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants