-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs #52
Update docs #52
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage 29.18% 29.18%
=======================================
Files 24 24
Lines 1261 1261
=======================================
Hits 368 368
Misses 893 893
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @felixhekhorn , I have added a couple of lines regarding |
Thanks @comane! At the moment, the best thing to do is definitely document, since we're trying to converge on a stable version. However, a proper solution to it will be #7 (most likely, since the only one using OpenSSL should be Git) |
@comane the moment you have updated the mg5 part, I'm ready for review; (Don't hesitate to reshuffle that part completely - as you can see I already did it so far, you can do it again) |
Actually it is cargo requiring ssl - so the solution is to use the pre-built binaries |
@felixhekhorn sorry I must have somehow missed this notification and just saw this. I have actually never used pinefarm |
@t7phy but you are running Matrix, right? so please consider seriously contributing to NNPDF/pinecards#161 (which should really be a pinefarm PR) |
that is true, however while using matrix, personally, I have to always do lots of tweaking based on the requirements of specific run, and this is very situation based and not straightforward or trivial and I am unsure of how much of this can be automated. perhaps we can discuss this some day on how to go about this (based on all the bits and pieces that need to be thought about for every run individually) |
Hi @felixhekhorn, I don't think I can actually contribute much to this PR. |
Closes #4
@comane and @t7phy can you please help? @andreab1997 maybe as well? just improve with your recent experience ...
e.g. we could consider adding the ssl discussion/snippet from #50 somewhere