-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace clone with download #7
Comments
latest release definetely about which repos are we talking about? because all python stuff (eko, yadism) should come without repo (but via PyPI). If we're not using releases (everywhere) we could likewise give up on poetry ;-) |
PineAPPL and MadGraph. In particular, for PineAPPL we need to install the C API, and it's not a great idea to ship it as Python package (but maybe I'm just wrong...). |
It should be possible to clone with no credentials. That said, agree with the following:
|
I thought so as well (for public repositories of course), but I was not able to do it with Ok, let's go for latest then! (unless @cschwan is strongly against it...) |
I guess also vrap @scarlehoff ? and to be more precise: let's not use |
Ok, that might be fine as well P.S.: for the non-python dependencies instead, I will hard-code versions in the package |
For the record: it is also possible to directly download tarballs even from Launchpad E.g. https://bazaar.launchpad.net/~maddevelopers/mg5amcnlo/simple_unlops/tarball/973 Of course, it is also supported by GitLab (and yes, also by GitHub, otherwise this issue would have not existed at all). This should make it completely possible to replace all clones by direct downloads of the required projects' versions (from any of the hosts we usually deal with). |
It seems that to clone a repository from GitHub now you always need to set credentials, whatever URL you are using.
So, I'm proposing to replace repositories (that in general are also an overkill) with the
master
/main
branch content, i.e. instead of cloning with Git we will just download the zip content of one branch from GitHub.E.g. for this repository the corresponding URL is https://github.com/NNPDF/runcards/archive/refs/heads/master.zip
The other option is to use the latest release, e.g. for PineAPPL the URL to the zip of the last release can be found with a request to:
https://api.github.com/repos/n3pdf/pineappl/releases/latest
(the key in the response is actually
zipball_url
). Once we have the URL, oneGET
more and we'll have the zip as well (for tarball replacezip
withtar
in the key.Which one do you prefer?
master
/main
: always updatedTODO:
pygit2
dependency, if not used for anything left3.4.1
, see Download mg5amc using git pinecards#142)The text was updated successfully, but these errors were encountered: