Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve expired cache update fixes #1174

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

gthess
Copy link
Member

@gthess gthess commented Nov 6, 2024

This tries to fix certain things related to serve-expired and cache updates:

  • If resolution fails, back off and use the expired entry for some time (default 5 seconds)
  • If serve-expired is set (but not serve-expired-client-timeout) still try to replace a SERVFAIL answer with an expired reponse
  • Exclude explicit RRSIG queries to require validation before being cached

@gthess gthess requested a review from wcawijngaards November 6, 2024 15:05
@gthess gthess self-assigned this Nov 6, 2024
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments elsewhere, but approved. Important to have a limit on work for expired contents that is served, otherwise every incoming query could turn into an upstream request, a request attempt for failing lookups.

@gthess gthess requested a review from wcawijngaards November 6, 2024 21:51
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! With serve expired, the norec_ttl is adjusted to stop repeated attempts, for a short duration, and the additional fix is a catch for additional cases where this is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants