-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve expired cache update fixes #1174
base: master
Are you sure you want to change the base?
Conversation
… of expired records.
enabled even without serve-expired-client-timeout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments elsewhere, but approved. Important to have a limit on work for expired contents that is served, otherwise every incoming query could turn into an upstream request, a request attempt for failing lookups.
response cannot update the usable expired entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good! With serve expired, the norec_ttl is adjusted to stop repeated attempts, for a short duration, and the additional fix is a catch for additional cases where this is needed.
This tries to fix certain things related to serve-expired and cache updates: