Add XFR middleware. #384
Add XFR middleware. #384
Commits on Sep 10, 2024
Commits on Sep 11, 2024
-
- Renamed AuthenticatedRequestMessage to RequestMessage to be consitent with src::net::client::request and to shorten the name (as it is scoped by the module so is still unique). - Renamed UpstreamSender to Forwarder as it's shorter and (I thnk) better. - Replaced HandleResponseResult by Option. - Renamed handle_response() to validate_response() and simplified the option/error handling a little. - Moved some impls around in the file to be nearer the type they affect.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Fix test compilation failure after merging with main including revers…
…ion of tsig mod KeyStore changes which is good anyway as they would have been breaking changes to stable interfaces.
-
-
-
-
-
Commits on Sep 12, 2024
-
-
- Don't pass the key store around, we need only the signer when post-processing. - Get tid of the mutex, we don't need it. - Don't clone metadata when invoking a stream post-processing callback. - Add key_wrapper() fn to ServerTransaction, ServerSequence and SigningContext to allow access to the key by its original type (which might e.g. be Arc<Key> allowing the Arc to be cloned rather than a deep copy being made).
-
-
-
-
-
-
-
Use the existing error response building functionality rather than ig…
…noring the actual error code.
-
-
- Handle TSIG response truncation using the existing ServerSequence i…
…f available, via a new TruncationContext type. - Truncate for TCP as well as UDP. - Return ServiceError::InternalError if truncation fails. - Implement handling of ServiceError in DgramServer and stream::Connection. - Break DgramServer and stream::Connection dispatch to service code out into helper RequestDispatcher types. - Terminate the response stream if ServiceError::InternalError occurs.
-
-
-
Commits on Sep 13, 2024
Commits on Sep 15, 2024
Commits on Sep 16, 2024
-
-
Leave xfr response processing out of client-transporrts.rs, keep it f…
…ocused on what it is supposed to show.
-
-
Rename XfrResponseProcessor to XfrResponseInterpreter, as it doesn't …
…do any processing of the data other than to translate it into a different higher level language, i.e. interpret it.
-
-
-
-
-
-
-
-
Update src/net/server/middleware/tsig.rs
Co-authored-by: Terts Diepraam <[email protected]>
-
Update src/net/server/middleware/tsig.rs
Co-authored-by: Terts Diepraam <[email protected]>
-
Update src/net/server/middleware/tsig.rs
Co-authored-by: Terts Diepraam <[email protected]>
-
-
Rename PostprocessingConfig to PostprocessingState to better reflect …
…its mutable nature.
-
-
Commits on Sep 17, 2024
-
Generalize the notion of zone updates, it need not be specific to XFR…
…, e.g. we may be able to use this for DNS UPDATE later as well.
-
-
-
Review feedback: Add
is_finished()method. Also variaous renames an……d minor improvements: rename `process_answer()` to `interpret_response()`, remove the unused `ZoneUpdate::Corrupt` enum variant, rename `ProcessingError` to `Error`, add `Error::Finished`.
-
-
-
-
-
-
-
-
-
-
-
-
-
Commits on Sep 18, 2024
-
-
Don't assume that an initial ZoneUpdate::AddRecord(soa) when updating…
… a zone means this is a full zone replacement so delete existing records, instead make the intent explcit by having XfrResponseInterpreter output ZoneUpdate::DeleteAllRecords before any other updates.
-
-
-
-
-
-
-
-
-
-
-
Commits on Sep 19, 2024
-
-
Remove questionable Serial::prev() addition, we don't want some mathe…
…matically earlier version anyway, we want the version prior to the one we are creating which is just the last version that was published by whatever number that had. Also improved some names to make it clearer what is being referred to.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Commits on Sep 20, 2024
-
-
-
-
-
-
-
-
FIX: Don't always rollback changes. Instead add the dirty flag back i…
…n, but this time make sure it is set and unset correctly.
-
Extend unit tet to verify created zone content is as expected. Catche…
…s the "always drop" bug that was just fixed.
Commits on Sep 23, 2024
-
Don't leave behind an empty RRset node for a version if the update re…
…moves all of its constituent RRs.
-
Don't skip deleted node versions when get()'ing the best match for a …
…node by version.
-
Determine ZoneDiff start and end serial from the given RRsets, so the…
…y can't be a mismatch with each other.
-
Determine ZoneDiff start and end serial from the given RRsets, so the…
…y can't be a mismatch with each other.
-
-
Various fixes and improvements:
- Release the write lock on ZoneUpdate::Finished and don't allow the ZoneUpdater to be used after that. - Remove the entire RRset if its' last record is removed. - Check more in tests and add more tests.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Commits on Sep 24, 2024
-
-
-
-
-
-
-
-
-
-
-
-
Don't require the diffs supplied to XfrMiddlewareSvc to be in-memory …
…HashMaps, instead abstract over the underlying implementation using a trait. Still needs proper RustDocs, and maybe async support.
-
Make ZoneDiff responses async, in case e.g. diffs are fetched from di…
…sk or a database.
-
Commits on Sep 25, 2024
-
-
- Actually cause SERVFAIL back to the client on fatal error. - Extract AXFR inner async tasks to own types. - Improved variable names in some cases. - Added `AnswerContent::first()` for less noisy uwrapping of data in XfrMiddlewareSvc.
-
-
Add RFC 1996 NOTIFY support. (#382)
Add RFC 1996 "slave" side minimalistic NOTIFY request support, delegating the actual work to a caller supplied helper that implements a new Notifiable trait.
-
-
-
-
-
-
-
Fix compilation bug with Rust 1.68.2 caused by an unnecessary HRTB (f…
…or<'a> ...) that Rust 1.69.0+ are fine with but 1.68.2 is not (perhaps due to rust-lang/rust#103695 which was fixed in Rust 1.69.0). Also reorder XfrMiddlewareSvc generic types to match the order used in other middleware services, i.e. add the extra type XDP at the end, not before RequestMeta. Also rename Metadata to RequestMeta as in other middleware services. (and fix a comment that is ahead of its time, there is no ZoneMaintainer yet in this branch)
-
-
Commits on Sep 26, 2024
-
-
- Fix temporarily removed support for RFC 5936 backward compatible mode.
- Handle parsing errors. - Introduce new XfrData type. - Use more functional style to improve readability.
-
-
-
-
-
-
Add some RustDocs about combining domain features to act as primary o…
…r secondary and doing zone maintenance.
-
-
-
Extend the serve-zone example with minimal AXFR out with support for …
…a hard-coded TSIG key and printing of received NOTIFY triggers.
-
-
-
-
-
-
-
-