Add serde::Serialize for AllRecordData.
#343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tertsdiepraam
commented
Jun 25, 2024
| derive(serde::Serialize), | ||
| serde(bound( | ||
| serialize = " | ||
| O: AsRef<[u8]> + octseq::serde::SerializeOctets, |
There was a problem hiding this comment.
@partim I copied this from elsewhere, but isn't AsRef<[u8]> always enough because we can do octs.as_ref().serialize_octets(serializer)?
There was a problem hiding this comment.
You are right. It’s possible that SerializeOctets was doing more things in an earlier iteration. Or I was just not thinking straight.
There was a problem hiding this comment.
Ah, but then you have to do your own Serialize impl, no? This way we can just derive it?
partim
changed the title
serde::Serialize for Opt recordsserde::Serialize for AllRecordData.
ximon18
pushed a commit
that referenced
this pull request
Oct 3, 2024
This PR adds a `Serialize` impl to `AllRecordData` and as a consequence to the OPT record and all OPT options, as well as `ParsedName`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with the JSON output in
dnsi.Deserializeis left for later, becasue we don't need it yet.