Added Emojis to README #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananyo2012
requested changes
Aug 4, 2017
README.md
Outdated
| @@ -1,13 +1,13 @@ | |||
| # Contribute[] | |||
|
|
|||
| Have you been looking for open source repositories to contribute? Look no further! You have come to right place. This gem will find active repositories from github to eat away your weekend time. Say goodbay to fruitless late night research, tiring click surfing and the voice in your head which make you feel guilty for not doing enough. Be warned! Your life will never be same after you have installed this gem. We offer all these unbelievbale features at a never before price of FREE! FREE! FREE! | |||
| Why are you still waiting? Get your terminals rolling, install this gem and experience the change. | |||
| Have you been looking for open source repositories to contribute :smile:?Look no further :wink:! You have come to right place. This :small_blue_diamond: gem will find active repositories from github to eat away your weekend time:clock2:. Say goodbye :smiley: to fruitless late night research :weary:, tiring click surfing and the voice in your head which make you feel guilty for not doing enough. Be warned :exclamation:Your life will never be same after you have installed this gem. We offer all these unbelievbale features at a never before price of:tada: :sparkles: FREE! FREE! FREE! :sparkles: | |||
There was a problem hiding this comment.
This line has way too much emojis. Remove some of them. The whole point of adding emojis is to make the readme interesting not to clutter the reading. So use it meaningfully. Like in headings or pointing to something.
There was a problem hiding this comment.
Ok @ananyo2012 The Readme was written in such a way that it felt like it could use them all.
But i guess you are correct, so i'll do as you say.
Also i made another commit and PR on #20
before i saw this review so i'll make the changes in the next commit
Thanks for reviewing 😄
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to add the emojis where possible. Maybe a bit too much 😁 . Hope you guys like it.