Removes Broken Wallpapers #300
Conversation
|
Hi thank you for your Patch make sure you have the right commit structure that is |
Fixes: #293
| try: | ||
| im.load() | ||
| self.show_image(self.image) | ||
| except IOError as e: |
There was a problem hiding this comment.
ok, will change that later, its of no harm though
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| from tkinter import * | |||
| from PIL import ImageTk | |||
| from PIL import Image | |||
| from uiplib.uipImage import UipImage | ||
| import os |
There was a problem hiding this comment.
You need to see PEP8 standard for importing.
There was a problem hiding this comment.
It did not give any linting error though
There was a problem hiding this comment.
@Aniq55 yes but we do have standard imports and it'll be better if we maintain them, can you check the wikis? i think we have it there.
| self.show_image(self.image) | ||
| im = Image.open(imagePath) | ||
| try: | ||
| im.load() |
There was a problem hiding this comment.
Are we sure this is how we want to do this? Maybe add this to UIP image object? Consult @abhsag24
There was a problem hiding this comment.
not sure myself, yes the UIP image class should be used but even then i'm not sure we should check here
There was a problem hiding this comment.
@abhsag24 If the approach needs to be different i.e. changes are to be made in a different file, then I think it is better if the PR is closed.
There was a problem hiding this comment.
@Aniq55 why do you think so?
There was a problem hiding this comment.
btw it would be better if you use our image class and make changes to that.
There was a problem hiding this comment.
Yeah, it's better using the wrapper @Aniq55. Don't close the PR, BTW.
There was a problem hiding this comment.
Alright! @nkprince007 @abhsag24
|
Closing as it's been unattended for too long. Reopen it if needed. |
Fixes: #293