Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created a grid for the info form page #307

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

DaltonDjoesman
Copy link

@DaltonDjoesman DaltonDjoesman commented Dec 8, 2024

Closes #286

created a grid for the info form page

Review checklist

  • Contains enough appropriate tests
  • Behavior is as expected
  • Clean, well-structured code

@DaltonDjoesman DaltonDjoesman linked an issue Dec 8, 2024 that may be closed by this pull request
@MRita443 MRita443 self-requested a review January 8, 2025 16:47
Copy link
Collaborator

@MRita443 MRita443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page is looking great so far! :) It would be great if you could extend the bar below the "Editar Projeto" a little more like this:

image

I think when you integrate the forms components you will be able to simplify the code a bit. You should also add this page to Storybook, if you need any help just tell me :)

Comment on lines 131 to 143
<div class="flex w-[50vw] mt-[10vw] gap-10">
<div class="h-10 w-[15vw] bg-red-500 rounded-xl flex items-center justify-center">
<p class="font-bold">
Guardar Alterações
</p>
</div>
<div class="h-10 w-[10vw] bg-gray-500 rounded-xl flex items-center justify-center">
<p class="font-bold">
Cancelar
</p>
</div>
</div>
</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the buttons you can use the already existing Button component!

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 165 lines in your changes missing coverage. Please review.

Project coverage is 9.87%. Comparing base (788c4e3) to head (f39638a).
Report is 67 commits behind head on develop.

Files with missing lines Patch % Lines
src/routes/(app)/projects/[id]/edit/+page.svelte 0.00% 164 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #307      +/-   ##
==========================================
+ Coverage     0.71%   9.87%   +9.16%     
==========================================
  Files           59      65       +6     
  Lines         2252    2998     +746     
  Branches        61     155      +94     
==========================================
+ Hits            16     296     +280     
- Misses        2179    2642     +463     
- Partials        57      60       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

projects: info form page
3 participants