Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Faculty Page #1449

Merged
merged 37 commits into from
Mar 18, 2025
Merged

Implementing Faculty Page #1449

merged 37 commits into from
Mar 18, 2025

Conversation

Pinho13
Copy link
Contributor

@Pinho13 Pinho13 commented Jan 25, 2025

closes #1422

Work in progress...

Progress:
image
image
image

@peucastro peucastro mentioned this pull request Feb 15, 2025
7 tasks
@DGoiana
Copy link
Collaborator

DGoiana commented Feb 21, 2025

TODO:

  • add arrows to the mobile and email row
  • add redirects to email and mobile
  • increase space between hours and title
  • increase space between hours and clock icon
  • add multiple cards to same services with different locations
  • add library card

@Adriano-7
Copy link
Member

Great job, just wanted to give you a heads up that the service card has this overflow issue on my phone !

@Pinho13
Copy link
Contributor Author

Pinho13 commented Feb 25, 2025

@DGoiana please look into the grey icons in the service card popup. Thanks!

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 2.24719% with 87 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (9ccbf8c) to head (0c10fd6).
Report is 39 commits behind head on ui/redesign.

Additional details and impacted files
@@             Coverage Diff             @@
##           ui/redesign   #1449   +/-   ##
===========================================
+ Coverage           11%     11%   +1%     
===========================================
  Files              271     263    -8     
  Lines             7785    7715   -70     
===========================================
- Hits               831     825    -6     
+ Misses            6954    6890   -64     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pinho13 Pinho13 requested a review from pedroafmonteiro March 18, 2025 19:00
@Pinho13
Copy link
Contributor Author

Pinho13 commented Mar 18, 2025

@DGoiana
@Atum555
someone please review this

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time consider using uni team for the reviewers :)

@thePeras thePeras merged commit 9863d12 into ui/redesign Mar 18, 2025
6 checks passed
@thePeras thePeras deleted the redesign/faculty-page branch March 18, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants