Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: Restaurant Page #1443

Open
wants to merge 6 commits into
base: ui/redesign
Choose a base branch
from
Open

Conversation

abutuc
Copy link

@abutuc abutuc commented Jan 14, 2025

Closes #1392

Latest Visual Version:

Latest Update:

  • Visually-wise, the only things that are missing in comparison to the mock is the different types of icons, the top-navbar part; and the translations overall.
  • Functionally-wise, the week day tabs, the dish filtering, favorite filtering, adding the restaurant to the user's preferences is done; however, the modal to add the favorite restaurant to the home page is not done.
  • Design-wise, currently the code is all mashed into a single file (the idea is to now divide it into individual widget files), the color codes and text styles are not using the theme (some colors from the mock are not in the theme), I am using a bad approach on favorite restaurant toggle by using a setState that re-renders the whole widget tree (therefore losing the scroll position).

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@abutuc abutuc marked this pull request as ready for review January 21, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant