Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average Bar #1303

Merged
merged 6 commits into from
Jan 19, 2025
Merged

Average Bar #1303

merged 6 commits into from
Jan 19, 2025

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Aug 21, 2024

Closes #1292

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@DGoiana
Copy link
Collaborator Author

DGoiana commented Aug 21, 2024

Screenshot 2024-08-21 at 23 43 03

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12%. Comparing base (8c559b5) to head (3da270b).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1303   +/-   ##
=======================================
  Coverage       12%     12%           
=======================================
  Files          265     265           
  Lines         7382    7382           
=======================================
  Hits           819     819           
  Misses        6563    6563           

@thePeras
Copy link
Member

Don't forget the status text below the progress bar, eg: "A frequentar"

@DGoiana DGoiana requested a review from a team October 16, 2024 22:19
limwa
limwa previously requested changes Oct 16, 2024
packages/uni_ui/lib/average_bar.dart Outdated Show resolved Hide resolved
packages/uni_ui/lib/average_bar.dart Outdated Show resolved Hide resolved
packages/uni_ui/lib/average_bar.dart Outdated Show resolved Hide resolved
packages/uni_ui/lib/average_bar.dart Outdated Show resolved Hide resolved
@DGoiana DGoiana requested review from vitormpp and limwa December 30, 2024 16:52
@thePeras thePeras dismissed limwa’s stale review January 19, 2025 17:45

requests done

@thePeras thePeras merged commit f874239 into develop Jan 19, 2025
6 checks passed
@thePeras thePeras deleted the ui/average-bar branch January 19, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Average bar
4 participants