Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete url_parser and use URI parser #1044

Closed
wants to merge 1 commit into from
Closed

Delete url_parser and use URI parser #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion uni/lib/controller/parsers/parser_course_units.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import 'package:html/parser.dart';
import 'package:http/http.dart' as http;
import 'package:uni/model/entities/course.dart';
import 'package:uni/model/entities/course_units/course_unit.dart';
import 'package:uni/utils/url_parser.dart';

List<CourseUnit> parseCourseUnitsAndCourseAverage(
http.Response response,
Expand Down
7 changes: 3 additions & 4 deletions uni/lib/controller/parsers/parser_courses.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import 'package:html/parser.dart' show parse;
import 'package:http/http.dart' as http;
import 'package:uni/model/entities/course.dart';
import 'package:uni/utils/url_parser.dart';

List<Course> parseMultipleCourses(List<http.Response> responses) {
final courses = <Course>[];
Expand All @@ -27,7 +26,7 @@ List<Course> _parseCourses(http.Response response) {
final courseUrl = div
.querySelector('.estudante-lista-curso-nome > a')
?.attributes['href'];
final courseId = getUrlQueryParameters(courseUrl ?? '')['pv_curso_id'];
final courseId = queryParameters(courseUrl ?? '')['pv_curso_id'];
final courseState = div.querySelectorAll('.formulario td')[3].text;
final courseFestId = div
.querySelector('.estudante-lista-curso-detalhes > a')
Expand All @@ -54,13 +53,13 @@ List<Course> _parseCourses(http.Response response) {
final div = oldCourses[i];
final courseName = div.children[0].firstChild?.text?.trim();
final courseUrl = div.querySelector('a')?.attributes['href'];
final courseId = getUrlQueryParameters(courseUrl ?? '')['pv_curso_id'];
final courseId = queryParameters(courseUrl ?? '')['pv_curso_id'];
var courseFirstEnrollment = div.children[4].text;
courseFirstEnrollment = courseFirstEnrollment
.substring(0, courseFirstEnrollment.indexOf('/'))
.trim();
final courseState = div.children[5].text;
final courseFestId = getUrlQueryParameters(
final courseFestId = queryParameters(
div.children[6].firstChild?.attributes['href'] ?? '',
)['pv_fest_id'];
courses.add(
Expand Down
Loading