Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow companies to be able to quickly edit publish end date from MyOffers menu #312

Closed
wants to merge 7 commits into from

Conversation

tomaspalma
Copy link
Member

@tomaspalma tomaspalma commented Feb 27, 2023

Why was this closed?

The way the team chose to implement this feature changed to the one in the pull request #315

What changed so that now is easier for companies to edit publiish end date from the See Offers page?

Instead of just showing the text of the date, it now:

  • Has an edit click button that popups a calendar
  • With the calendar, companies just need to click on the desired date and if is valid, it is updated and it is immediately shown to them. If the date is invalid, a snackbar appears stating so and the date is not changed neither visually to the user nor in the backend.

Video of the feature implemented

2023-03-27.23-08-29.mp4

@ttoino ttoino linked an issue Feb 28, 2023 that may be closed by this pull request
@tomaspalma tomaspalma force-pushed the feature/easy-extend-pub-offer-date-305 branch from e9006a7 to 233530a Compare March 6, 2023 10:55
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2023

Codecov Report

Patch coverage: 62.85% and project coverage change: -0.28 ⚠️

Comparison is base (d47281c) 89.01% compared to head (4223578) 88.73%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #312      +/-   ##
===========================================
- Coverage    89.01%   88.73%   -0.28%     
===========================================
  Files          175      176       +1     
  Lines         3322     3355      +33     
  Branches       837      842       +5     
===========================================
+ Hits          2957     2977      +20     
- Misses         365      378      +13     
Impacted Files Coverage Δ
src/components/Offers/Form/OfferUtils.js 60.71% <0.00%> (-2.25%) ⬇️
...rc/components/Offers/Edit/OfferEndDateQuickEdit.js 58.62% <58.62%> (ø)
src/utils/Table/utils.js 94.73% <100.00%> (+0.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tomaspalma tomaspalma force-pushed the feature/easy-extend-pub-offer-date-305 branch from 03b1d03 to 3bfb168 Compare March 20, 2023 22:24
@tomaspalma tomaspalma closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend offer publish date
2 participants