Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend mailto: when company inserts an email in one click application #302

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

Process-ing
Copy link
Contributor

Closes #256

Screenshot from 2023-02-03 13-06-15
Screenshot from 2023-02-03 19-36-23
Screenshot from 2023-02-03 19-36-33

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Base: 88.98% // Head: 88.97% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (8a40c01) compared to base (5f96cb4).
Patch coverage: 66.66% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #302      +/-   ##
===========================================
- Coverage    88.98%   88.97%   -0.02%     
===========================================
  Files          175      175              
  Lines         3306     3311       +5     
  Branches       833      834       +1     
===========================================
+ Hits          2942     2946       +4     
- Misses         364      365       +1     
Impacted Files Coverage Δ
src/components/Offers/New/CreateOfferForm.js 24.00% <ø> (+0.92%) ⬆️
src/components/Offers/Form/OfferUtils.js 62.96% <57.14%> (+1.05%) ⬆️
src/components/Offers/Edit/EditOfferForm.js 92.06% <100.00%> (ø)
...s/Offers/Form/form-components/ApplyURLComponent.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@BrunoRosendo BrunoRosendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I only have some minor cosmetic suggestions

@Process-ing Process-ing force-pushed the feature/prepend-mailto branch from 56cb72e to 8a40c01 Compare February 8, 2023 13:56
Copy link
Member

@BrunoRosendo BrunoRosendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Looks good

@Process-ing Process-ing force-pushed the feature/prepend-mailto branch from 8a40c01 to 6f9c38d Compare February 8, 2023 16:18
@Naapperas
Copy link
Member

@Process-ing rebase

@Process-ing Process-ing force-pushed the feature/prepend-mailto branch from 6f9c38d to a2661d9 Compare February 15, 2023 14:06
@Process-ing Process-ing merged commit 6d13452 into develop Feb 28, 2023
@Process-ing Process-ing deleted the feature/prepend-mailto branch February 28, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepend mailto: when company inserts an email in one click application
4 participants