Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook to allow the search trough the click of a chip #283

Merged
merged 7 commits into from
Apr 11, 2023

Conversation

DoStini
Copy link
Contributor

@DoStini DoStini commented Nov 29, 2022

Closes #221

@DoStini DoStini force-pushed the feature/chip-search branch 4 times, most recently from ecebc4d to 6fec0f6 Compare December 19, 2022 16:36
@DoStini DoStini marked this pull request as ready for review December 19, 2022 16:37
@DoStini DoStini force-pushed the feature/chip-search branch 2 times, most recently from 1baad63 to ecd0669 Compare December 19, 2022 18:02
@DoStini DoStini force-pushed the feature/chip-search branch 2 times, most recently from a60e51c to 052b4b3 Compare January 24, 2023 15:00
@Naapperas
Copy link
Member

Since we have no backend to test this (at the moment), please include a small video demonstrating this feature.

Copy link
Member

@Naapperas Naapperas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake, the previous comments are change requests

@DoStini DoStini force-pushed the feature/chip-search branch from 4a3a258 to f782aa1 Compare March 28, 2023 13:56
@DoStini DoStini force-pushed the feature/chip-search branch from 75efff2 to 83ec120 Compare April 11, 2023 14:34
Copy link
Member

@Naapperas Naapperas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DoStini DoStini merged commit 014bd1d into develop Apr 11, 2023
@DoStini DoStini deleted the feature/chip-search branch April 11, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking in a badge searches for that field/tech
2 participants