Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started writing more rules #201

Merged
merged 12 commits into from
Apr 8, 2022
Merged

Started writing more rules #201

merged 12 commits into from
Apr 8, 2022

Conversation

Naapperas
Copy link
Member

Closes #196

@Naapperas Naapperas force-pushed the feature/write-rules branch from 2451bdc to 35ca2ba Compare March 24, 2022 21:51
@imnotteixeira imnotteixeira force-pushed the feature/write-rules branch 3 times, most recently from 24e625d to 95f1d0d Compare March 27, 2022 16:38
@Naapperas Naapperas force-pushed the feature/write-rules branch 2 times, most recently from 22a4d67 to 470fb14 Compare March 28, 2022 11:28
@Naapperas Naapperas marked this pull request as ready for review March 28, 2022 11:56
src/components/RulesPage/rules.js Outdated Show resolved Hide resolved
src/components/RulesPage/rules.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/components/RulesPage/rules.js Outdated Show resolved Hide resolved
src/components/RulesPage/rules.js Outdated Show resolved Hide resolved
Copy link
Contributor

@DoStini DoStini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const useStyles = makeStyles((theme) => ({
ruleCard: {
marginBottom: theme.spacing(2),
},
}));

Try to add a bit of padding to make it look consistent with the privacy policy and terms and conditions pages

content: ({ isMobile }) => ({
padding: isMobile ? theme.spacing(0, 1) : theme.spacing(10),
}),

@Naapperas
Copy link
Member Author

const useStyles = makeStyles((theme) => ({
ruleCard: {
marginBottom: theme.spacing(2),
},
}));

Try to add a bit of padding to make it look consistent with the privacy policy and terms and conditions pages

content: ({ isMobile }) => ({
padding: isMobile ? theme.spacing(0, 1) : theme.spacing(10),
}),

I'm not that keen on web design: could you clarify this a bit, please ?

@Naapperas
Copy link
Member Author

Also, one thing I think could be better is adding some top margin to a rule's link: right now it feels to close to the rule's text. What do you think ?

@Naapperas Naapperas force-pushed the feature/write-rules branch 5 times, most recently from 0c2cadd to 804d771 Compare March 29, 2022 15:45
@Naapperas Naapperas requested a review from DoStini March 29, 2022 16:53
src/components/RulesPage/rules.js Outdated Show resolved Hide resolved
src/components/RulesPage/rules.js Outdated Show resolved Hide resolved
src/components/RulesPage/rules.js Outdated Show resolved Hide resolved
@Naapperas Naapperas force-pushed the feature/write-rules branch from 67ae2b3 to 3c6e797 Compare March 30, 2022 22:48
src/components/RulesPage/rules.js Outdated Show resolved Hide resolved
src/components/RulesPage/rules.js Outdated Show resolved Hide resolved
src/components/RulesPage/rules.js Outdated Show resolved Hide resolved
src/components/RulesPage/rules.js Show resolved Hide resolved
@TiagooGomess
Copy link
Contributor

Consider changing some of the occurrences of "please contact us" to "please get in touch with us" or "don't hesitate to get in touch with us".

@Naapperas Naapperas force-pushed the feature/write-rules branch from 3c6e797 to 39977d0 Compare April 1, 2022 14:21
@Naapperas Naapperas force-pushed the feature/write-rules branch from 39977d0 to 926eff9 Compare April 2, 2022 19:51
@Naapperas Naapperas force-pushed the feature/write-rules branch from 3bc2c0e to 94817c2 Compare April 8, 2022 10:45
@Naapperas Naapperas merged commit 906afdb into develop Apr 8, 2022
@Naapperas Naapperas deleted the feature/write-rules branch April 8, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write rules
4 participants