-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Started writing more rules #201
Conversation
2451bdc
to
35ca2ba
Compare
24e625d
to
95f1d0d
Compare
22a4d67
to
470fb14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nijobs-fe/src/components/RulesPage/index.js
Lines 16 to 20 in 470fb14
const useStyles = makeStyles((theme) => ({ | |
ruleCard: { | |
marginBottom: theme.spacing(2), | |
}, | |
})); |
Try to add a bit of padding to make it look consistent with the privacy policy and terms and conditions pages
nijobs-fe/src/components/Offers/New/form-components/Policies/PoliciesStyle.js
Lines 10 to 12 in 17ad3b7
content: ({ isMobile }) => ({ | |
padding: isMobile ? theme.spacing(0, 1) : theme.spacing(10), | |
}), |
I'm not that keen on web design: could you clarify this a bit, please ? |
Also, one thing I think could be better is adding some top margin to a rule's link: right now it feels to close to the rule's text. What do you think ? |
0c2cadd
to
804d771
Compare
67ae2b3
to
3c6e797
Compare
Consider changing some of the occurrences of "please contact us" to "please get in touch with us" or "don't hesitate to get in touch with us". |
3c6e797
to
39977d0
Compare
39977d0
to
926eff9
Compare
Currently importing 'nijobs-common' produces a compilation error that should be fixed soon
3bc2c0e
to
94817c2
Compare
Closes #196