fix: errors while rendering status pages

website/.env.example

@@ -36,7 +36,7 @@ LINKEDIN_CLIENT_ID=********
 LINKEDIN_CLIENT_SECRET=********
 
 # Feature flags
-FEATURES_DISABLE_AUTH=true
+FEATURES_DISABLE_AUTH=false
 
 # Frontend
 INERTIA_PUBLIC_TZ=Europe/Lisbon

website/app/exceptions/handler.ts

@@ -14,7 +14,7 @@ export default class HttpExceptionHandler extends ExceptionHandler {
    * codes. You might want to enable them in production only, but feel
    * free to enable them in development as well.
    */
-  protected renderStatusPages = true
+  protected renderStatusPages = app.inProduction
 
   protected ignoreCodes = ["E_AUTH_DISABLED"]
 
@@ -23,9 +23,12 @@ export default class HttpExceptionHandler extends ExceptionHandler {
    * to return the HTML contents to send as a response.
    */
   protected statusPages: Record<StatusPageRange, StatusPageRenderer> = {
-    '403': (error, { inertia }) => inertia.render('errors/forbidden', { error }),
-    '404': (error, { inertia }) => inertia.render('errors/not_found', { error }),
-    '500..599': (error, { inertia }) => inertia.render('errors/server_error', { error }),
+    // '403': (error, { inertia }) => inertia.render('errors/forbidden', { error }),
+    '403': (_error, { response }) => response.status(403).finish(),
+    // '404': (error, { inertia }) => inertia.render('errors/not_found', { error }),
+    '404': (_error, { response }) => response.status(404).finish(),
+    // '500..599': (error, { inertia }) => inertia.render('errors/server_error', { error }),
+    '500..599': (_error, { response }) => response.status(500).finish(),
   }
 
   /**

website/app/middleware/require_authentication_enabled_middleware.ts

@@ -3,7 +3,7 @@ import env from '#start/env'
 import type { HttpContext } from '@adonisjs/core/http'
 import type { NextFn } from '@adonisjs/core/types/http'
 
-export default class RequireAuthEnabledMiddleware {
+export default class RequireAuthenticationEnabledMiddleware {
   async handle(_ctx: HttpContext, next: NextFn) {
     if (env.get('FEATURES_DISABLE_AUTH')) {
       throw new AuthenticationDisabledException()

website/inertia/hooks/use_auth.ts

@@ -12,13 +12,10 @@ type UseAuthResult<Props extends UseAuthProps> = Props["only"] extends (infer On
   : AuthenticationData
 
 export function useAuth<Props extends UseAuthProps>(props?: Props) {
-  const only = props?.only ?? []
+  const only = props?.only
 
   const auth = usePage<SharedProps>().props.auth
-  const valid = useMemo<boolean>(() => {
-    if (only === undefined) return true
-    return only.includes(auth.state)
-  }, [auth, only])
+  const valid = useMemo(() => only?.includes(auth.state) ?? true, [auth, only])
 
   if (!valid) throw new Error('Assertion failed: authentication state is not permitted')
 

website/inertia/pages/errors/forbidden.tsx

@@ -1,6 +1,6 @@
 import BaseLayout from '~/layouts/base'
 
-export default function Forbidden({}: { error: any }) {
+export default function Forbidden() {
   return (
     <BaseLayout title="You should not be here">
       <div className="">