Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ticket-selection-page #11

Merged
merged 17 commits into from
Dec 27, 2024
Merged

Feature/ticket-selection-page #11

merged 17 commits into from
Dec 27, 2024

Conversation

hugo2006alm
Copy link
Contributor

@hugo2006alm hugo2006alm commented Dec 21, 2024

Added Tickets Database Model, Migration and Seeder and done page for choosing tickets

Desktop

image

Mobile

image

@limwa limwa self-requested a review December 22, 2024 16:24
Copy link
Member

@limwa limwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design is very good! Also, there are some things that must be changed in the code.

website/app/models/ticket.ts Outdated Show resolved Hide resolved
website/inertia/pages/tickets.tsx Outdated Show resolved Hide resolved
website/inertia/pages/tickets.tsx Outdated Show resolved Hide resolved
website/inertia/pages/tickets.tsx Outdated Show resolved Hide resolved
website/inertia/app/tuyau.ts Outdated Show resolved Hide resolved
website/.adonisjs/api.ts Outdated Show resolved Hide resolved
@limwa
Copy link
Member

limwa commented Dec 27, 2024

Oh, and to fix the conflicts in package-lock.yaml, you can just run pnpm install, as long as there are no conflicts in package.json or they've already been resolved.

@hugo2006alm
Copy link
Contributor Author

hugo2006alm commented Dec 27, 2024

Defining Routes with Tuyau

To use Tuyau in your routes, you need to update the API file each time you do certain actions, mainly:

  1. Adding a new route/controller to your project
  2. Adding a request.validateUsing call in your controller method

This is done with the command

node ace tuyau:generate

More info here: Tuyau - Installation

@limwa
Copy link
Member

limwa commented Dec 27, 2024

Defining Routes with Tuyau

To use Tuyau in your routes, you need to update the API file each time you do certain actions, mainly:

  1. Adding a new route/controller to your project
  2. Adding a request.validateUsing call in your controller method

This is done with the command

node ace tuyau:generate

More info here: Tuyau - Installation

Please add this information to the project's README.md, under the website folder.

@limwa limwa force-pushed the feature/ticket-selection-page branch from 3c4ccde to fc87b4a Compare December 27, 2024 16:56
@limwa limwa force-pushed the feature/ticket-selection-page branch from c6e740e to 6d642b4 Compare December 27, 2024 17:22
@limwa limwa merged commit e5d58d5 into main Dec 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants