Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug coverage #18

Closed
wants to merge 8 commits into from
Closed

debug coverage #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
452668a
debug coverage
anthony-nhs Feb 5, 2024
4e9d922
trigger build
anthony-nhs Feb 5, 2024
19a1d5a
set sources for coverage
anthony-nhs Feb 5, 2024
89c9544
verbose sonar
anthony-nhs Feb 5, 2024
3d7f522
remove exclusions
anthony-nhs Feb 6, 2024
2c961a7
exclude all coverage options
anthony-nhs Feb 6, 2024
24d3414
Merge branch 'main' into fix_coverage
anthony-nhs Feb 6, 2024
c8ad895
force coverage
anthony-nhs Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/quality_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,14 @@ jobs:
- name: run unit tests
run: make test

- name: debug
run: ls coverage

- name: SonarCloud Scan
uses: SonarSource/sonarcloud-github-action@master
with:
args: >
-Dsonar.verbose=true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
1 change: 1 addition & 0 deletions sonar-project.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ sonar.host.url=https://sonarcloud.io

sonar.coverage.exclusions=**/*.test.*,**/jest.config.ts,scripts/*
sonar.javascript.lcov.reportPaths=coverage/lcov.info
sonar.sources=.
4 changes: 2 additions & 2 deletions src/live-spine-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import axios, {Axios, AxiosRequestConfig, AxiosResponse} from "axios"
import {APIGatewayProxyEventHeaders} from "aws-lambda"

// timeout in ms to wait for response from spine to avoid lambda timeout
const SPINE_TIMEOUT = 45000
const SPINE_TIMEOUT = 43000

export class LiveSpineClient implements SpineClient {
private readonly SPINE_URL_SCHEME = "https"
Expand Down Expand Up @@ -76,7 +76,7 @@ export class LiveSpineClient implements SpineClient {
timeout: SPINE_TIMEOUT
})

// This can be removed when https://nhsd-jira.digital.nhs.uk/browse/AEA-3448 is complete
// This can be removed when https://nhsd-jira.digital.nhs.uk/browse/AEA-3448 is complete change comment
if (
response.data["statusCode"] !== undefined &&
response.data["statusCode"] !== "1" &&
Expand Down
Loading