Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DTOSS-6682 CaaSFile failure read changes #569

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

feat: DTOSS-6682 CaaSFile failure read changes #569

wants to merge 27 commits into from

Conversation

Swapnil261188
Copy link
Contributor

Description

To implement the CaaSFileIntegration file failure reading as exception and storing the file in the BlobStorage

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

MWClayson-NHS
MWClayson-NHS reviewed Jan 17, 2025
View reviewed changes
application/CohortManager/src/Functions/CaasIntegration/receiveCaasFile/receiveCaasFile.cs Outdated
@@ -83,6 +86,9 @@ public async Task Run([BlobTrigger("inbound/{name}", Connection = "caasfolder_ST
allTasks.Add(
_processCaasFile.ProcessRecords(batch, options, screeningService, name)
);
allTasks.Add(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this not insert the records twice as you are calling both process records and process records with retry

application/CohortManager/src/Functions/Shared/Common/StateStore.cs Outdated
/// </summary>
/// <param name="fileName">The name of the file.</param>
/// <returns>A task representing the asynchronous operation.</returns>
public async Task ClearProcessingState(string fileName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method isn't doing anything?

sudipnhs
sudipnhs previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@sudipnhs sudipnhs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if you could address Michael's comments

@sudipnhs sudipnhs self-requested a review January 17, 2025 10:01
@will-larkin-nhs will-larkin-nhs dismissed their stale review January 17, 2025 10:03

Need to see demo before this is merged

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MWClayson-NHS MWClayson-NHS MWClayson-NHS requested changes

@will-larkin-nhs will-larkin-nhs will-larkin-nhs left review comments

@sudipnhs sudipnhs Awaiting requested review from sudipnhs

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Swapnil261188 @sudipnhs @will-larkin-nhs @MWClayson-NHS @SamRobinson75684