Resource tagging #23
Merged
Resource tagging #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tagging of the resources created by the module. Tags are configured as a map of strings in the terraform variables.
Also included in this PR is info in the docs about tagging, and test coverage to check the tags are set correctly.
Type of change
Please check the relevant options, or cross through options which are not applicable to this change:
✅ New feature (a change which adds functionality)
🔲
Bug fix (a change which fixes an issue)🔲
Refactoring (code cleanup or optimisation)✅ Testing (new tests, or improvements to existing tests)
🔲
Pipelines (changes to pipelines and workflows)✅ Documentation (changes to documentation)
🔲
Other (something that's not listed here - please explain)Checklist
Please check the relevant options, or cross through options which are not applicable to this change:
✅ My code aligns with the style of this project
✅ I have added comments in hard to understand areas
✅ I have added tests that prove my change works
✅ I have updated the documentation
Additional Information
n/a