Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grazing #1140
base: main
Are you sure you want to change the base?
Grazing #1140
Changes from 18 commits
ee5ef88
bc633e2
dbd692d
580df9e
c62e98d
cab4ee7
cb5ea6d
dcbf787
2b36e09
9e035dd
3f755f0
4e818e8
b67019d
53a6a44
636e003
2b87e44
c039964
e7b236b
ac5bf38
b3113b7
6fa3079
4b100b2
76225c9
b619100
da70f55
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to help me understand the steps, will the leaf litter here already take into account the leaf mass that is consumed and "stays" in the animal as food, and only a portion returning to the litter as "manure"? Is that the herbivory_element_use_efficiency parameter, or something else? Because I'm also confused about what portion of the litter is food, is manure, and/or to the atmosphere, and if all 3 paths are tracked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual grazing animals here (as with all heterotrophs in the soil BGC code) aren't tracked, they only exist as a transformation of leaf biomass to either litter (proportional to
herbivory_element_use_efficiency
) or the atmosphere (proportional to1- herbivory_element_use_efficiency
) . So this pathway here is the fraction that is returned to litter. In principle this is via manure (and I guess some fraction of animals die while grazing), but for simplicity we are just tracking it as flux into the leaf litter pool, so that it gets a shallow vertical profile like other sources of leaf litter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing
herbivory_flux_out
is actually sent to the atmosphere by the HLM, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it isn't yet, but will be in a future update.