Reload daemons for Logstash restart #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might make reloads a bit slower but it seems to be the only chance to deal with changes in the Logstash unit file. We're not managing this file witht the collection, so changing it manually is fine. If someone does, we need to reload the unit file. fixes #342
afeefghannam89
approved these changes
Sep 25, 2024
I would also vote for one handler which covers all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reload unit files when restart Logstash via handler. We're running the handler for upgrades of the package, not only when changing configuration.
This might make reloads a bit slower but it seems to be the only chance to deal with changes in the Logstash unit file. We're not managing this file with the collection, so changing it manually is fine.
If someone does, we need to reload the unit file.
We could introduce a separate handler. One for upgrades of the package that does the daemon reload and another without reload for regular configuration changes. @frankhetterich @afeefghannam89 @martialblog what do you think? I went for one handler which does it all but that's just a suggestion so far.
Thank you, @frankhetterich for the bug report and the suggested fix.
fixes #342