-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable use of uniqe tls passwords pr host #344
Conversation
Hm... it seems like the |
Hum, my understanding was that The problem I'm trying to fix is caused by the certificate generation loop only running when |
…rch_tls_key_passphrase" set
…k to playbook or role default if not
Apparently there are 3 variable scopes in Ansible, and I've fixed the PR so it uses the variable from |
Thanks! Let's see what the tests are saying. :-) |
Great. Could please just fix the linter findings? |
Fixed linting. Note: This PR also changes one of the molecule scenarios in order to fully test the implemented fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you! This looks like a great addidtion.
Allow use of unique
elasticsearch_tls_key_passphrase
pr host(not sure if this is a fix or a feature, but I went with fix as that's the behaviour I expected)