Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/137 avoid wallet confirmation #488

Conversation

petersalomonsen
Copy link
Collaborator

@petersalomonsen petersalomonsen commented Nov 18, 2023

work in progress to resolve #137

this depends on NearSocial/VM#156 where you can also find a preview environment

@petersalomonsen petersalomonsen force-pushed the feat/137-avoid-wallet-confirmation branch from e80cded to db61d46 Compare November 19, 2023 10:57
@ailisp
Copy link
Collaborator

ailisp commented Nov 28, 2023

Hi @petersalomonsen ! What's the status of this ticket? Any blockers?

@petersalomonsen
Copy link
Collaborator Author

petersalomonsen commented Nov 28, 2023

Hi @ailisp

There are no blockers, but all the work is currently going on in this PR NearSocial/VM#156

You can find a preview environment in there as well.

Everything works, but there are two remaining things to conclude on:

-Avoid reloading the page after a completed transactions. My idea on how to sove this is to inject transactionHashes into the top level props

  • When adding the function access key to the wallet, the message should be an application is trying to get limited access to your account. Currently you have to really pay attention and inspect the transaction to see that adding a function access key is part of what you are confirming in the wallet. I haven't looked into how to solve this yet.

My plan is to conclude on this by the end of this week ( by the end of the weekend ).

Please have a look on the current progress in the PR in the VM, and any comments on the current state are welcome. Would be great with your feedback too @nearmax

@petersalomonsen
Copy link
Collaborator Author

NearSocial/VM#156 could need some comments now.

Also we need to fix this issue: #549

@petersalomonsen
Copy link
Collaborator Author

This upgrades to the latest near-bos-webcomponent, that also supports the wallet selector, so would like to keep this PR for a little longer and see how we can test wallet confirmation related stuff.

@petersalomonsen petersalomonsen force-pushed the feat/137-avoid-wallet-confirmation branch from a644d75 to a6a9548 Compare March 5, 2024 19:01
@petersalomonsen
Copy link
Collaborator Author

petersalomonsen commented Mar 13, 2024

Will close this, as I believe it is not needed anymore. We have solved it in NearSocial/VM#156, and we have tests for the "Don't ask again" feature here in the DevHub repository. The devcontainer and gateway adjustments are also all in place through #687

@petersalomonsen petersalomonsen deleted the feat/137-avoid-wallet-confirmation branch March 13, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid a need to confirm every DevHub post/like through a Wallet
2 participants