-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/137 avoid wallet confirmation #488
Feat/137 avoid wallet confirmation #488
Conversation
e80cded
to
db61d46
Compare
Hi @petersalomonsen ! What's the status of this ticket? Any blockers? |
Hi @ailisp There are no blockers, but all the work is currently going on in this PR NearSocial/VM#156 You can find a preview environment in there as well. Everything works, but there are two remaining things to conclude on: -Avoid reloading the page after a completed transactions. My idea on how to sove this is to inject
My plan is to conclude on this by the end of this week ( by the end of the weekend ). Please have a look on the current progress in the PR in the VM, and any comments on the current state are welcome. Would be great with your feedback too @nearmax |
NearSocial/VM#156 could need some comments now. Also we need to fix this issue: #549 |
This upgrades to the latest near-bos-webcomponent, that also supports the wallet selector, so would like to keep this PR for a little longer and see how we can test wallet confirmation related stuff. |
a644d75
to
a6a9548
Compare
Will close this, as I believe it is not needed anymore. We have solved it in NearSocial/VM#156, and we have tests for the "Don't ask again" feature here in the DevHub repository. The devcontainer and gateway adjustments are also all in place through #687 |
work in progress to resolve #137
this depends on NearSocial/VM#156 where you can also find a preview environment