Changed project structure #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonElia
commented
Sep 20, 2024
harshil21
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Definitely like the new hardware folder. Still on the fence on whether the data packets should be in their own file, or inside imu.py, where they are initialized and used.
Github CI is failing because of removed requirements.txt. Should be fixed by adding pip install .[dev]
|
Can you also change the path of the logs for the |
harshil21
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't happy with how our project was structured. We had too many files in airbrakes/ and I didn't like how we just had the imu folder. Also, I moved constants to the same level as main because main.py uses some constants.
To review this pr, I would just go to the branch and look at the new structure.