Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More unit tests, fix bug when running main.py #10

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Conversation

harshil21
Copy link
Member

Todo:

  • Fix airbrakes Ctrl+C handling so I can finish writing the tests. Can be done in another PR. Currently things can silently fail in another process, which can cause memory to grow out of bounds (e.g. when packets are added to the queue and we never retrieve them) and lead to the system being completely unresponsive. Code overall needs to be more error resistant.

Bug fix:

  • cyclic import when running main.py
  • data processing failing because of no EstimatedDataPackets produced when first starting the script.

Other minor changes:

  • better encapsulation
  • make pin_factory an __init__ argument so it becomes easier to test with MockFactory in the tests later.

@harshil21 harshil21 added bug Something isn't working tests For PR's which improve tests labels Sep 17, 2024
@JacksonElia JacksonElia merged commit 821d91f into main Sep 17, 2024
2 checks passed
@JacksonElia JacksonElia deleted the more-tests branch September 17, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests For PR's which improve tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants