Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes second line of Cycle code in importMIDN. #114

Closed
wants to merge 1 commit into from

Conversation

sjperles
Copy link
Collaborator

Closes #113.

@johnpauls
Copy link
Member

I think the issue is that Cycles2 is used for the NCBN parks as they are on a slightly different cycle.

@KateMMiller
Copy link
Collaborator

Cycles2 is there because parks in NCBN are off from MIDN by a year, although the visualizer doesn't treat NCBN parks differently yet (I think), so it should be okay to delete that line of code for now.

@KateMMiller
Copy link
Collaborator

Actually, I just found places in importMIDN that call in Cycles2: Lines 186, 294, 321. To make this work for the PennState shiny server, you'll need to change those to InCycles. I'm not sure if this is a change we want to make with the NPSForVeg package just yet though, since it's technically not the correct cycle info for NCBN's parks. I'll leave that up to JP whether or not to make this change to the master NPSForVeg package. I'm also curious what this has been causing problems with the PSU shiny server when it runs fine on my computer. Will this be a problem with the NPS server at FOCO too?

@sjperles
Copy link
Collaborator Author

sjperles commented Jun 13, 2018 via email

@johnpauls
Copy link
Member

Putting in an identical Cycle2.csv ile should work fine. Should not be a problem for FOCO server.

@johnpauls johnpauls closed this Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants