-
Notifications
You must be signed in to change notification settings - Fork 2
Update routes to Strapi #2328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update routes to Strapi #2328
Conversation
ef4bceb
to
be097e8
Compare
fc399fd
to
7261a49
Compare
00c5823
to
c4f6633
Compare
c4f6633
to
60ec7fb
Compare
60ec7fb
to
045b250
Compare
045b250
to
6c5a2b3
Compare
336f215
to
a12c045
Compare
This should be almost good to go once @A-Wheeto has completed the enrolment resource card component. One thing to double check before go live
We have NOT migrated the careers support page. This is due to having to make a benchmark variants of all the components, and this seems excessive for one page. |
a12c045
to
a113d7d
Compare
0f2a76f
to
5639b67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, always love to see a PR that's mostly deletions. I would say the routes that are no longer needed in the routes file would be much better deleted than commented out if there is no expectation to need them again any time soon 👍
Switch secondary-teachers to CMS Updating site searchable tests
Removing padding from secondary question bank component for better placement on the page Fixing check for aside icons in aside component as this was returning true falsely
…nent that was matching a class with icon, but wasn't testing for the correct icon class
… breaking off the side of the page
|
Status
Review progress:
What's changed?
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.