Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin zarr<3 #238

Merged
merged 6 commits into from
Feb 11, 2025
Merged

Pin zarr<3 #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aaecbce
pin zarr
valeriupredoi Feb 11, 2025
da73b77
pin zarr
valeriupredoi Feb 11, 2025
505f0c1
upgrade to v4 artifact
valeriupredoi Feb 11, 2025
daa2281
run a GHA cover our arses
valeriupredoi Feb 11, 2025
52d0d2c
set overwrite true
valeriupredoi Feb 11, 2025
08242ba
unrun GHA
valeriupredoi Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test_s3_minio.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,9 @@ jobs:
run: tests/s3_exploratory/minio_scripts/minio-stop
if: always()
- name: Upload HTML report artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: html-report
path: test-reports/
overwrite: true
if: always()
3 changes: 2 additions & 1 deletion .github/workflows/test_s3_remote_reductionist.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,9 @@ jobs:
run: |
pytest tests/test_compression_remote_reductionist.py
- name: Upload HTML report artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: html-report
path: test-reports/
overwrite: true
if: always()
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ dependencies:
- s3fs >=2024.2.0 # loose s3fs deps leading to old aiobotocore for <2024.2.0
# pin Zarr to avoid using old KVStore interface
# see github.com/zarr-developers/zarr-python/issues/1362
- zarr >=2.13.6 # KVStore to FSStore
- zarr >=2.13.6,<3 # KVStore to FSStore, zarr=3 massive refactoring
# Python packages for testing
- moto # mock S3 tests
- pytest
Expand Down
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
'requests',
's3fs>=2024.2.0', # see environment.yml for pin reason
# pin Zarr to use new FSStore instead of KVStore
'zarr>=2.13.3', # github.com/zarr-developers/zarr-python/issues/1362
# also pin to avoid massive refactoring with zarr>=3
'zarr>=2.13.3,<3', # gh/zarr-developers/zarr-python/issues/1362
# for testing
'moto', # mock S3 tests
'pytest',
Expand Down
Loading