Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set count to 0 for 0-sized data #197

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Set count to 0 for 0-sized data #197

merged 2 commits into from
Apr 25, 2024

Conversation

davidhassell
Copy link
Collaborator

Fixes #194

Raised against branch pyfive for @bnlawrence

This small change should have made it into #196 !

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • All tests pass

@valeriupredoi
Copy link
Collaborator

@davidhassell look at my test fixes here 8b46b4b pls bud, and let me know if this is OK with you, then I'll approve and merge - cheers muchly! 🍺

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (b43dd21) to head (8b46b4b).
Report is 1 commits behind head on pyfive.

Additional details and impacted files
@@           Coverage Diff           @@
##           pyfive     #197   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files           7        7           
  Lines         550      550           
=======================================
  Hits          498      498           
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi
Copy link
Collaborator

@davidhassell look at my test fixes here 8b46b4b pls bud, and let me know if this is OK with you, then I'll approve and merge - cheers muchly! 🍺

frenly ping @davidhassell 🐔 TBF I completely forgot about it myself 😆

@valeriupredoi valeriupredoi added the bug Something isn't working label Apr 15, 2024
@davidhassell
Copy link
Collaborator Author

Hi V - finally got round it it :) 8b46b4b looks fine to me, thanks.

@valeriupredoi
Copy link
Collaborator

yay! Cheers @davidhassell 🍺

@valeriupredoi valeriupredoi merged commit e4f2067 into pyfive Apr 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants