Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin kerchunk >=0.2.4 and fix change of API in new Kerchunk: compressor is now a filter #192

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

valeriupredoi
Copy link
Collaborator

@valeriupredoi valeriupredoi commented Mar 18, 2024

Description

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • All tests pass

kerchunk=0.2.2 is very old; kerchunk=0.2.3 had issues with numcodecs dependencies; kerchunk=0.2.4is nice and happy and has an optimization we worked on, but it moved thecompressor and compressor level inside thefiltersdictionary - this PR fixes that; also, this PR pins Kerchunk to>=0.2.4` so we don't have to run into old issues, and be able to use the optimization (selection on Dataset or Group to do kerchunking on)

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 87.78%. Comparing base (9e2bfd3) to head (20a246c).

Files Patch % Lines
activestorage/netcdf_to_zarr.py 75.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   88.40%   87.78%   -0.62%     
==========================================
  Files           8        8              
  Lines         664      696      +32     
==========================================
+ Hits          587      611      +24     
- Misses         77       85       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi valeriupredoi added bug Something isn't working installation labels Mar 18, 2024
@valeriupredoi valeriupredoi merged commit bcbc108 into main Mar 18, 2024
9 of 10 checks passed
@valeriupredoi valeriupredoi deleted the fix_compressor_as_filter branch March 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant