[DRAFT] Pyfive Masterpiece #189
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a pre-train interim commit
…led with zarr dependencies
…tiveStorage into pyfive
…we need to read the chunk cache before sending things off into the weeds).
…alone method which I don't like. We would be better to pull that out and do this differently. I also fixed the disgusting test ...
|
all tests back to green @bnlawrence 🍺 @davidhassell pls update your branch for testing, if you hit issues |
|
this branch needs fixing for @bnlawrence 's newest Pyfive main branch, doing it now |
…iveStorage into fix_pyfive_branch
… hack for contiguous data.
…into fix_pyfive_branch
…into fix_pyfive_branch
Fix `pyfive` branch with latest Pyfive branch `h5netdf`
bnlawrence
reviewed
Jan 22, 2025
There was a problem hiding this comment.
@valeriupredoi Can you please remove all the stuff under bnl so we keep a clean main? We can keep the branch hanging around so I don't lose my stuff. Maybe my stuff should go into your testing repository?
|
On it! But AFAIK it's only the JASMIN bucket that bears your name, will have a looksee |
|
OK all tests using the |
|
tested with the standard gold tests (64 and 3400 chunks): same times as with optimal Kerchunk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bnlawrence I opened a PR with it for ease of checking the tests 🍺
pyfivebranch with latest Pyfive branchh5netdf#234 5f67387bnlS3 bucket removed from here, to be found in a separate branch https://github.com/NCAS-CMS/PyActiveStorage/tree/pyfive_with_bnl