Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numcodecs>=0.12 to avoid compression kerfuffle for Python<3.12 #163

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

valeriupredoi
Copy link
Collaborator

@valeriupredoi valeriupredoi commented Dec 4, 2023

Description

Closes #162

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • [ ] Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • All tests pass

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcf9e4b) 86.95% compared to head (4e0e36b) 86.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files           8        8           
  Lines         621      621           
=======================================
  Hits          540      540           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi valeriupredoi merged commit 24757cf into main Dec 4, 2023
6 checks passed
@valeriupredoi valeriupredoi deleted the pin_numcodecs branch December 4, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numcodecs==0.11 is creating compression confusion and test fail
1 participant