Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conda-lock] do not install pip post-facto and use it straight from the lock environment #161

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

valeriupredoi
Copy link
Collaborator

@valeriupredoi valeriupredoi commented Dec 1, 2023

…onment

Description

conda lock install tests failing prompted me to a vulnerability that should have been corrected long ago 👍 Instead of installing pip post-facto (after environment has been created) with the risk of overwriting the correctly installed version via conda lock, we just keep what came with the lock file.

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • All tests pass

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (324c4ba) 86.95% compared to head (5d04ae4) 86.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files           8        8           
  Lines         621      621           
=======================================
  Hits          540      540           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi
Copy link
Collaborator Author

S3Minio tests need fixing too, will do that in a separate PR 👍

@valeriupredoi valeriupredoi merged commit bcf9e4b into main Dec 1, 2023
3 of 6 checks passed
@valeriupredoi valeriupredoi deleted the use_lock_pip branch December 1, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant