Added netcdf #273
Merged
Added netcdf #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K20shores
reviewed
Nov 4, 2024
K20shores
requested changes
Nov 4, 2024
K20shores
requested changes
Nov 6, 2024
K20shores
approved these changes
Nov 7, 2024
K20shores
requested changes
Nov 7, 2024
K20shores
requested changes
Nov 7, 2024
There was a problem hiding this comment.
If you run this
music_box -e Analytical --output-format netcdf
output is printed to the screen as csv data. There is not a printable netcdf format since it's a binary format. So, when the output is netcdf and no output path is given, I think we need to output anyway. Choose a default filename (maybe results, this would also close #237) and set the suffix to .nc or .csv based on the output format. What do you think?
K20shores
approved these changes
Nov 8, 2024
K20shores
previously approved these changes
Nov 8, 2024
boulderdaze
previously approved these changes
Nov 8, 2024
boulderdaze
reviewed
Nov 8, 2024
montythind
dismissed stale reviews from mattldawson and boulderdaze
via
9e9b090
boulderdaze
approved these changes
Nov 12, 2024
K20shores
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMD argument is available to define type of file.
Units have been added to csv file header
units added to header in netcdf
close #238 and #237